PHPC-2443: Deprecate string argument and accept Int64 instances in UTCDateTime constructor #1643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Sep 11, 2024
alcaeus
force-pushed
the
phpc-2443-deprecate-string-argument-utcdatetime
branch
from
5174744 to
151409f
Compare
jmikola
approved these changes
Sep 13, 2024
This was referenced Sep 13, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPC-2443
This PR deprecates creating a
MongoDB\BSON\UTCDateTimeinstance with a string, which was previously used to pass values exceeding the 32-bit range on 32-bit platforms. WithMongoDB\BSON\Int64available to the user, this has been replaced with the constructor accepting those values. I've updated all existing string usages in tests toInt64instances, except where explicitly testing string inputs.