PHPC-2401: Support QEv2 range protocol #1583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
Jun 13, 2024
| 'contentionFactor' => 0, | ||
| 'rangeOpts' => ['min' => 0, 'max' => 200, 'sparsity' => 1], | ||
| 'rangeOpts' => ['min' => 0, 'max' => 200, 'sparsity' => 1, 'trimFactor' => 1], |
There was a problem hiding this comment.
Once we get language tickets for DRIVERS-2927, sparsity and trimFactor can be removed as they'll no longer be required by libmongocrypt. That's also going to necessitate a bump to libmongocrypt 1.11.0 (MONGOCRYPT-698).
| string(43) "AEAD_AES_256_CBC_HMAC_SHA_512-Deterministic" | ||
| string(36) "AEAD_AES_256_CBC_HMAC_SHA_512-Random" | ||
| string(7) "Indexed" | ||
| string(9) "Unindexed" | ||
| string(12) "RangePreview" | ||
| string(5) "Range" | ||
| %Astring(12) "RangePreview" |
There was a problem hiding this comment.
PHP 8.3+ emits deprecation notices when referencing these constants. I'm sure that has to do with using ZEND_ACC_DEPRECATED to define the constant, but it's not clear to me why earlier versions don't report anything. I found no mention of this in the 8.3 migration guide.
In any event, I thought it easier to conditionally ignore the notices instead of split this test into two.
Existing RANGE_PREVIEW constants are deprecated in favor of new RANGE constants introduced in libmongoc 1.28.0
This is temporary until sparsity and trimFactor are made optional prior to the GA release for range indexes (PHPC-2403)
alcaeus
added a commit
that referenced
this pull request
Sep 4, 2024
* master: (22 commits) PHPC-2434: Add PHP 8.4 to GitHub Actions (#1625) PHPC-2421, PHPC-2428: Update bundled dependencies (#1622) Don't build libmongoc version in pull requests Use drivers-evergreen-tools for Windows testing (#1615) PHPC-1957 Add tests for out-of-range UTCDateTime values (#1614) PHPC-2286 Implement `UTCDateTime::toDateTimeImmutable` (#1611) PHPC-2414, PHPC-2415: Update wire versions for MongoDB 8.0 compatibility (#1610) PHPC-2349, PHPC-2411: Deprecate unused exception classes (#1608) Fix failing tests on x86 systems (#1609) PHPC-2347: Deprecate BSON functions (#1607) PHPC-1489: Deprecate integer readPreference constants (#1604) Fix version computation for libmongoc development versions (#1599) PHPC-2376: Test against MongoDB 8.0 (#1598) PHPC-2254: Relax server selection timeout error message pattern (#1587) PHPC-2401: Support QEv2 range protocol (#1583) PHPC-2398: Use server_id methods for libmongoc 1.28+ (#1582) PHPC-2395: Fetch Atlas connectivity URIs from AWS Secrets Manager (#1579) Merge v1.19 into master (#1578) Revert "Bump mongodb-labs/drivers-github-tools from 1 to 2 (#1568)" (#1571) Bump mongodb-labs/drivers-github-tools from 1 to 2 (#1568) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2401
Depends on #1582