Fix use of testing.T instead of mtest.T in assertions in subtests. #1963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the correct
mtest.T
instance inside subtests to make assertions.Background & Motivation
Some subtests written using
mtest
use thetesting.T
from the outer test function when making assertions. That results in confusing test failures that don't directly indicate which subtest failed. See an example:That also corrupts the test failure info in Evergreen CI. The fix is to use the
mtest.T
instance provided in the subtest func.