GODRIVER-2872 Fix failing "TestClientSideEncryptionProse" test. #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingyang-hu
force-pushed
the
godriver2872
branch
5 times, most recently
from
e755a82 to
bbb9bc7
Compare
qingyang-hu
force-pushed
the
godriver2872
branch
from
0b73f1f to
c9b02c3
Compare
qingyang-hu
had a problem deploying
to
api-report
GitHub Actions
Failure
qingyang-hu
force-pushed
the
godriver2872
branch
from
c9b02c3 to
1a41f03
Compare
qingyang-hu
had a problem deploying
to
api-report
GitHub Actions
Failure
qingyang-hu
force-pushed
the
godriver2872
branch
from
1a41f03 to
a13f6ef
Compare
qingyang-hu
had a problem deploying
to
api-report
GitHub Actions
Failure
qingyang-hu
force-pushed
the
godriver2872
branch
from
a13f6ef to
b38f4ac
Compare
qingyang-hu
had a problem deploying
to
api-report
GitHub Actions
Failure
qingyang-hu
force-pushed
the
godriver2872
branch
from
b38f4ac to
bcf5f70
Compare
qingyang-hu
had a problem deploying
to
api-report
GitHub Actions
Failure
qingyang-hu
requested review from
matthewdale and
prestonvasquez
and removed request for
a team
API Change ReportNo changes found! |
matthewdale
approved these changes
Aug 28, 2023
prestonvasquez
approved these changes
Aug 30, 2023
qingyang-hu
added a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2872
Summary
Fix the failing "TestClientSideEncryptionProse" test by duplicating the memory passed to the C side.
Background & Motivation
The original comment was not accurate. The C side mongocrypt_binary_new_from_data() does a shallow copy of the passed array only, while the Golang slice which holds the memory may be freed or moved by GC.
Once a GC happens, for example, between C.mongocrypt_binary_new_from_data() and C.mongocrypt_ctx_encrypt_init(), the memory block pointed by
C.mongocrypt_binary_tgets corrupted and resulted in sporadic "invalid BSON".This PR proposes
C.CBytes()to sync the lifecycle of the memory with the C code. Eventually, we can utilize runtime.Pinner (introduced in Go1.21.0) to avoid additional memory usage.