bson/bsoncodec: code review comments

charlievieth · charlievieth · commit 9de8c88edbf8 · 2023-07-31T20:49:40.000-04:00
diff --git a/bson/bsoncodec/codec_cache_test.go b/bson/bsoncodec/codec_cache_test.go
@@ -13,6 +13,8 @@ import (
 	"testing"
 )
 
+// NB(charlie): the array size is a power of 2 because we use the remainder of
+// it (mod) in benchmarks and that is faster when the size is a power of 2.
 var codecCacheTestTypes = [16]reflect.Type{
 	reflect.TypeOf(uint8(0)),
 	reflect.TypeOf(uint16(0)),

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@ import (`
`13`	`13`	`"testing"`
`14`	`14`	`)`
`15`	`15`
	`16`	`+// NB(charlie): the array size is a power of 2 because we use the remainder of`
	`17`	`+// it (mod) in benchmarks and that is faster when the size is a power of 2.`
`16`	`18`	`var codecCacheTestTypes = [16]reflect.Type{`
`17`	`19`	`reflect.TypeOf(uint8(0)),`
`18`	`20`	`reflect.TypeOf(uint16(0)),`