CXX-2661 Add macos-1100 tasks and move ubuntu1404 -> ubuntu2204 #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a first step for CXX-2661, adds macos-1100 equivalent tasks for existing macos-1014 tasks. Removal of old macos-1014 tasks would fully resolve CXX-2661.
Additionally, tasks on ubuntu1404 were moved to ubuntu2204 per distro guidelines, resolving CXX-2657 and ongoing failures in the waterfall.
The Apple Clang compiler on the macos-1100 distro appears to have a new warning enabled,
-Wrange-loop-analysis, which are also addressed by this PR.Verified by this patch.
Boost Polyfill Detection
Example projects were updated to replace Windows-only special handling of the conditional Boost dependency, and instead generically detect the use of the Boost polyfill library via the
CMakeCXXSymbolExistsmodule to detect the presence of theBSONCXX_POLY_USE_BOOSTpreprocessor macro. This avoids example project build failure when compiling with Boost on MacOS.Note: this only applies to the example projects using the deprecated CMake project config files, as the newer CMake project config files automatically handles the Boost dependency detection and inclusion (see #968 (review) for more context).