Skip to content

Retry valgrind curl command via script instead of --retry #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

eramongodb
Copy link
Contributor

@eramongodb eramongodb commented Apr 22, 2025

Followup to #1383 to address spurious task failure due to the following error:

curl: (16) Error in the HTTP2 framing layer

curl does not appear to --retry for this error code. Considered using --retry-all-errors, but docs state:

This option is the "sledgehammer" of retrying. Do not use this option by default (for example in your curlrc), there may be unintended consequences such as sending or receiving duplicate data. Do not use with redirected input or output. You'd be much better off handling your unique problems in shell script. Please read the example below.

Therefore, applied the suggestion to handle the problem via shell script by using a simple for loop in Bash instead of --retry 5. The subsequent sha1sum command will fail if the curl command did not succeed with either:

sha1sum: valgrind-3.24.0.tar.bz2: No such file or directory
sha1sum: WARNING: 1 listed file could not be read

or:

sha1sum: WARNING: 1 computed checksum did NOT match

@eramongodb eramongodb requested a review from kevinAlbs April 22, 2025 21:00
@eramongodb eramongodb self-assigned this Apr 22, 2025
@eramongodb eramongodb requested a review from a team as a code owner April 22, 2025 21:00
@eramongodb eramongodb merged commit efc46c3 into mongodb:master Apr 23, 2025
19 of 21 checks passed
@eramongodb eramongodb deleted the cxx-valgrind branch April 23, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants