Use looseversion instead of deprecated distutils #1391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following warning observed when running the
make_release.py
script:This is a followup to #1280 and #1244, which applied a
<3.12
Python version restriction to workaround the aforementioned removal of thedistutils
package. This PR proposes using the looseversion package instead to obtainLooseVersion
. This package was already added to the list ofmake_release.py
dependencies in #1244 but was left unused (possibly overlooked?).This permits the removal of the Python 3.12 version restriction, which in turn revealed the following warning:
This is apparently due to 3.12 promoting unrecognized escape sequences to a SyntaxWarning (and eventually a SyntaxError). I believe a simple addition of an escape
\
->\\
is sufficient in this case.These changes (should) allow for compatibility with Python 3.10 through Python 3.13. ("Should" as the full script is not yet tested without
--dry-run
.)