Attempt to address miscellaneous integration task errors on macos-14-arm64 #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Jan 30, 2025
| # RegEx pattern to match SemVer strings. See https://semver.org/. | ||
| declare -r semver_regex="^(?P<major>0|[1-9]\d*)\.(?P<minor>0|[1-9]\d*)\.(?P<patch>0|[1-9]\d*)(?:-(?P<prerelease>(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+(?P<buildmetadata>[0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$" | ||
| if echo "${mongoc_version}" | perl -ne "$(printf 'exit 1 unless /%s/' "${semver_regex}")"; then | ||
| # If $VERSION is already SemVer compliant, use as-is. |
There was a problem hiding this comment.
Suggested change
| # If $VERSION is already SemVer compliant, use as-is. | |
| # If $mongoc_version is already SemVer compliant, use as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preemptive changes to address macos-14-arm64 task failures observed during work on CXX-2665.
The curl command to obtain the tag name of the latest release seems to spuriously fail due to unknown reasons specifically when executed on MacOS distros. Following CDRIVER-4809 add a
VERSION_CURRENTfile mongo-c-driver#1521, aVERSION_CURRENTfile is guaranteed for latest releases, so that file is detected and used instead when available.The
start-mongod.shscript occasionally fails on MacOS distros due to permission errors. A call tochmod -xis added to ensure binaries underMONGODB_BINARIESare actually executable as they should be. An obsolete workaround for rhel9 distros is removed in favor of a simple fallback routine for legacy mongo shell binaries.A
-Wsign-conversionwarning blocks compilation of examples on MacOS distros when maintainer flags are enabled. The warning is addressed by an explicit cast tostd::size_tfromstd::int64_t.