CXX-3179 Set ENABLE_TESTS=OFF by default #1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3179. Verified by this patch.
Changes the default value of
ENABLE_TESTSfromONtoOFF.Tweaked descriptions of CMake options to better document how they are conditioned on
ENABLE_TESTS=ON(e.g.BUILD_TESTING=ONalone does not enable test targets). In particular, the difference betweenBUILD_TESTING(add test targets to "all") andENABLE_TESTS(enable the test targets which may be added to "all") is clarified by the addition of a warning whenBUILD_TESTING=ON+ENABLE_TESTS=OFF(which suggests a conflict of intent).All instances of
ENABLE_TESTS=OFFin Evergreen scripts (except inspec.patch) are removed in favor of using off-by-default behavior. All EVG tasks which require test targets or their corresponding build artifacts now explicitly setENABLE_TESTS=ON(which atm always impliesBUILD_TESTING=ON). In short, building test targets is now explicitly opt-in both in CMake configuration and in Evergreen scripts.