Skip to content

CXX-3070 Address -Wdocumentation Clang warnings #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

eramongodb
Copy link
Contributor

Summary

Resolves CXX-3070.

-Wdocumentation

Notable fixes include:

  • Misplacement of type aliases between a function and its intended documentation.
  • Incorrect name in @param name.
  • Redundant commands without useful documentation.

-Wdocumentation-deprecated-sync

Some of these warnings were addressed by changing the @deprecated to a @warning, such as when the command is referring to an entity other than what is currently being documented.

However, these warnings are for the most part ignored and left unaddressed. Applying [[deprecated]] or *_DEPRECATED (from the export header) to relevant entities produces too many -Wdeprecated-declarations warnings. This currently applies to:

  • bsoncxx::v_noabi::types::b_undefined (type)
  • bsoncxx::v_noabi::types::b_dbpointer (type)
  • bsoncxx::v_noabi::types::b_symbol (type)
  • mongocxx::v_noabi::database::create_collection_deprecated (member function)
  • mongocxx::v_noabi::options::find::comment (member functions (2))

We may revisit these another time with a methodology that doesn't trigger so many -Wdeprecated-declarations warnings within our own code (or in users' code despite no direct usage).

@eramongodb eramongodb requested a review from kevinAlbs July 23, 2024 20:41
@eramongodb eramongodb self-assigned this Jul 23, 2024
@eramongodb eramongodb marked this pull request as ready for review July 23, 2024 20:41
@eramongodb eramongodb merged commit dc971ed into mongodb:master Jul 24, 2024
66 of 76 checks passed
@eramongodb eramongodb deleted the cxx-3070 branch July 24, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants