CSHARP-5779: Removed a small amount of unused code

rstam · rstam · commit 6f7337c0366e · 2025-11-08T11:00:14.000-05:00
diff --git a/src/MongoDB.Driver/Linq/Linq3Implementation/Translators/ExpressionToAggregationExpressionTranslators/MemberExpressionToAggregationExpressionTranslator.cs b/src/MongoDB.Driver/Linq/Linq3Implementation/Translators/ExpressionToAggregationExpressionTranslators/MemberExpressionToAggregationExpressionTranslator.cs
@@ -216,7 +216,7 @@ private static bool TryTranslateDictionaryProperty(TranslationContext context, M
                             case "Keys":
                                 var keysAst = dictionaryRepresentation switch
                                 {
-                                    DictionaryRepresentation.Document or DictionaryRepresentation.ArrayOfDocuments => AstExpression.Map(containerAst, kvpVar, AstExpression.GetField(kvpVar, "k")),
+                                    DictionaryRepresentation.ArrayOfDocuments => AstExpression.Map(containerAst, kvpVar, AstExpression.GetField(kvpVar, "k")),
                                     DictionaryRepresentation.ArrayOfArrays  => AstExpression.Map(containerAst, kvpVar, AstExpression.ArrayElemAt(kvpVar, 0)),
                                     _ => throw new ExpressionNotSupportedException(expression, $"Unexpected dictionary representation: {dictionaryRepresentation}")
                                 };
@@ -231,7 +231,7 @@ private static bool TryTranslateDictionaryProperty(TranslationContext context, M
                                 {
                                     var kvpPairsAst = dictionaryRepresentation switch
                                     {
-                                        DictionaryRepresentation.Document or DictionaryRepresentation.ArrayOfDocuments => containerAst,
+                                        DictionaryRepresentation.ArrayOfDocuments => containerAst,
                                         DictionaryRepresentation.ArrayOfArrays => AstExpression.Map(containerAst, kvpVar, AstExpression.ComputedDocument([("k", AstExpression.ArrayElemAt(kvpVar, 0)), ("v", AstExpression.ArrayElemAt(kvpVar, 1))])),
                                         _ => throw new ExpressionNotSupportedException(expression, $"Unexpected dictionary representation: {dictionaryRepresentation}")
                                     };
@@ -243,7 +243,6 @@ private static bool TryTranslateDictionaryProperty(TranslationContext context, M
                                 {
                                     var valuesAst = dictionaryRepresentation switch
                                     {
-                                        DictionaryRepresentation.Document => AstExpression.Map(AstExpression.ObjectToArray(containerAst), kvpVar, AstExpression.GetField(kvpVar, "v")),
                                         DictionaryRepresentation.ArrayOfArrays => AstExpression.Map(containerAst, kvpVar, AstComputedArrayExpression.ArrayElemAt(kvpVar, 1)),
                                         DictionaryRepresentation.ArrayOfDocuments => AstExpression.Map(containerAst, kvpVar, AstExpression.GetField(kvpVar, "v")),
                                         _ => throw new ExpressionNotSupportedException(expression, $"Unexpected dictionary representation: {dictionaryRepresentation}")

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ private static bool TryTranslateDictionaryProperty(TranslationContext context, M`
`216`	`216`	`case "Keys":`
`217`	`217`	`var keysAst = dictionaryRepresentation switch`
`218`	`218`	`{`
`219`		`- DictionaryRepresentation.Document or DictionaryRepresentation.ArrayOfDocuments => AstExpression.Map(containerAst, kvpVar, AstExpression.GetField(kvpVar, "k")),`
	`219`	`+ DictionaryRepresentation.ArrayOfDocuments => AstExpression.Map(containerAst, kvpVar, AstExpression.GetField(kvpVar, "k")),`
`220`	`220`	`DictionaryRepresentation.ArrayOfArrays => AstExpression.Map(containerAst, kvpVar, AstExpression.ArrayElemAt(kvpVar, 0)),`
`221`	`221`	`_ => throw new ExpressionNotSupportedException(expression, $"Unexpected dictionary representation: {dictionaryRepresentation}")`
`222`	`222`	`};`
`@@ -231,7 +231,7 @@ private static bool TryTranslateDictionaryProperty(TranslationContext context, M`
`231`	`231`	`{`
`232`	`232`	`var kvpPairsAst = dictionaryRepresentation switch`
`233`	`233`	`{`
`234`		`- DictionaryRepresentation.Document or DictionaryRepresentation.ArrayOfDocuments => containerAst,`
	`234`	`+ DictionaryRepresentation.ArrayOfDocuments => containerAst,`
`235`	`235`	`DictionaryRepresentation.ArrayOfArrays => AstExpression.Map(containerAst, kvpVar, AstExpression.ComputedDocument([("k", AstExpression.ArrayElemAt(kvpVar, 0)), ("v", AstExpression.ArrayElemAt(kvpVar, 1))])),`
`236`	`236`	`_ => throw new ExpressionNotSupportedException(expression, $"Unexpected dictionary representation: {dictionaryRepresentation}")`
`237`	`237`	`};`
`@@ -243,7 +243,6 @@ private static bool TryTranslateDictionaryProperty(TranslationContext context, M`
`243`	`243`	`{`
`244`	`244`	`var valuesAst = dictionaryRepresentation switch`
`245`	`245`	`{`
`246`		`- DictionaryRepresentation.Document => AstExpression.Map(AstExpression.ObjectToArray(containerAst), kvpVar, AstExpression.GetField(kvpVar, "v")),`
`247`	`246`	`DictionaryRepresentation.ArrayOfArrays => AstExpression.Map(containerAst, kvpVar, AstComputedArrayExpression.ArrayElemAt(kvpVar, 1)),`
`248`	`247`	`DictionaryRepresentation.ArrayOfDocuments => AstExpression.Map(containerAst, kvpVar, AstExpression.GetField(kvpVar, "v")),`
`249`	`248`	`_ => throw new ExpressionNotSupportedException(expression, $"Unexpected dictionary representation: {dictionaryRepresentation}")`