-
Notifications
You must be signed in to change notification settings - Fork 1.4k
PHPORM-77 Rename project #2576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPORM-77 Rename project #2576
Conversation
dfc7436
to
0e9fc93
Compare
CHANGELOG.md
Outdated
|
||
- Rename package to `mongodb/laravel-eloquent` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rename package to `mongodb/laravel-eloquent` | |
- Rename package to `mongodb/laravel` |
Hello,
Sorry to ask but wouldn't it be better to rename the package to mongodb/laravel
as it's easy to remember and to type as well...
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed that's a good question that we are discussing with @alcaeus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will follow @chalasr recommendation and name the composer package like the GitHub project: mongodb/laravel-mongodb
to eliminate any ambiguity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
This doesn’t make sense. If you use namespace MongoDB/Laravel
then the package name should follow it?
Maybe change the namespace as well or should each and every package named twice? Like mysql/laravel-mysql
it’s already under MySQL organization and you can understand that it’s especially for Laravel. I’m sure you’ll ask what was the reason behind it, well, there is no logical reason behind it.
Anyway, looks like I’m not a collaborator anymore and my suggestion doesn’t have any power. No problem.
Looking at all libraries under MongoDB organizations there are a lot of repositories that start with mongo-
If I'm going to install a PHP library like:
composer require mongodb/mongodb
Which of the following would make sense to install the Laravel version?
composer require mongodb/laravel-mongodb
composer require mongodb/mongodb-laravel
composer require mongodb/mongo-laravel
composer require mongodb/laravel
This is a very important question that needs a quite good decision because later you won't be able to change the package name...
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @divine.
At first sight I wasn't convinced by this duplication either, but that's the best name we can find.
In mongodb/laravel-mongodb
, the 1st mongodb
it the vendor: the MongoDB company taking over the maintenance. The 2nd laravel-mongodb
is the package name that indicate this is a package for both Laravel (the framework) and MongoDB (the database).
In the same way, the project needs to be in MongoDB's GitHub organisation. We keep the project name laravel-mongodb
that is commonly used to refer to this project in issues and docs. When forking the project for contribution, the fork name stay descriptive even if it loose it's org part.
If we called it mongodb/laravel
, this could be interpreted as a fork of laravel/laravel
.
Having a match between the project name on GitHub and the package name in Composer make things easier for developers to locate the source code of the package from its name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, looks like I’m not a collaborator anymore and my suggestion doesn’t have any power. No problem.
Your work on this project is remarkable. I want you to be able to continue to contribute as you are doing.
Permissions management has changed with the move to MongoDB's GitHub organization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merging now makes some links invalid until we move the repo to the mongodb org, but that's a risk I'm willing to take.
Co-authored-by: Andreas Braun <[email protected]>
I'll merge it tomorrow morning. |
Hello, Probably this deserves a new issue but sorry for writing it here. The only thing that catched my eyes is https://www.mongodb.com/compatibility/mongodb-laravel-intergration link which still refers old library name a lot. Those names at that link should be probably updated so it will consistent with the documentation on Github to make it clear that MongoDB Inc. is the developer for this library and it works very well. Thanks! |
Fix PHPORM-77
MongoDB\Laravel
mongodb/laravel-mongodb
https://github.com/mongodb/laravel-mongodb