-
Notifications
You must be signed in to change notification settings - Fork 259
fix(NODE-5056): EJSON.parse date handling when useBigInt64=true #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-5056): EJSON.parse date handling when useBigInt64=true #562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry jumping on this early just noticed some things
|
Should we change the tsdoc comment for the
Having a subclass by the name of |
|
Sounds like a good improvement although there's still plenty of usage of it, someday we'll have descriptive errors as needed. We can make it more generic and omit the "runtime" bit. "thrown when BSON encounters an error" and then maybe an additional note about how it is the parent of all other errors we intentionally throw. |
Description
EJSON.parsefails to correctly deserialize cEJSON strings which contain date fields.What is changing?
EJSON.parsenow correctly deserializes cEJSON datesBSONErrorsubclass,BSONRuntimeErrorto cover internal failuresIs there new documentation needed for these changes?
No
Double check the following
npm run lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript