Skip to content

Fixed mongo shell data types Date() description #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed mongo shell data types Date() description #2855

wants to merge 1 commit into from

Conversation

maganap
Copy link

@maganap maganap commented Mar 16, 2017

new Date() constructor returns a Date() object, but NOT using the ISODate() wrapper. That description belongs to the line below, where ISODate() constructor is described.


This change is Reviewable

new Date() constructor returns a Date() object, but NOT using the ISODate() wrapper. That description belongs to the line below, where ISODate() constructor is described.
@p-mongo
Copy link

p-mongo commented Mar 3, 2020

Actually no, new Date returns an ISODate instance:

ruby-driver-rs:SECONDARY> new Date
ISODate("2020-03-03T23:00:46.910Z")
ruby-driver-rs:SECONDARY> ISODate()
ISODate("2020-03-03T23:01:09.940Z")

The existing language appears to be correct.

@kay-kim
Copy link
Contributor

kay-kim commented Mar 3, 2020

Thanks for this pull request and apologies for the long delay. As the behavior describes what happens in the mongo shell, and as shown above, new Date() does return the ISODate, will close without merge. However, we appreciate your taking the time to help improve our docs, and apologies again for the delay.

Regards,

Kay Kim

@kay-kim kay-kim closed this Mar 3, 2020
@maganap
Copy link
Author

maganap commented Mar 3, 2020

I really can't remember now what happened back then that made me notice this issue. Maybe that was the behaviour 2 years ago in an older version? xD
Thanks for reviewing the case anyway. Have a great week!

@kay-kim
Copy link
Contributor

kay-kim commented Mar 3, 2020

You too. Thanks again!

mongo-cr-bot pushed a commit that referenced this pull request Mar 30, 2023
…yPath (#2753) (#2855)

* DOCSP-28680 Add Restart Warning for diagnosticDataCollectionDirectoryPath

* copy cleanup

* IF feedback

* move warning message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants