Skip to content

DOCS-540 add dropTarget option to renameCollection #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 1, 2012
Merged

DOCS-540 add dropTarget option to renameCollection #259

merged 6 commits into from
Oct 1, 2012

Conversation

epc
Copy link
Contributor

@epc epc commented Sep 24, 2012

  • add dropTarget option
  • add exceptions thrown
  • rewrite to indicate that shell helper command operates within a collection but the admin command can copy a collection to a new database

Ed Costello added 2 commits September 24, 2012 13:52
@epc
Copy link
Contributor Author

epc commented Sep 24, 2012

Note this also addresses DOCS-537

@tychoish
Copy link
Contributor

Scott/Ed,

Is this ready for merging?

Cheers,
sam

@epc
Copy link
Contributor Author

epc commented Sep 26, 2012

No, don't merge. There was a stub db.collection.renameCollection which I'm going to beef up and then link to from this, and remove other discussion about "shell helper" from this document.

@epc
Copy link
Contributor Author

epc commented Sep 26, 2012

@scotthernandez can you review? I updated the helper method documentation, think I straightened out the command documentation, and removed the sentences about atomicity/speed entirely.

@scotthernandez
Copy link
Contributor

We should add a warning that copying across databases will have a performance impact, and space requirements. It should also not be done while the source collection is being written to if a copy must be made.

@epc
Copy link
Contributor Author

epc commented Oct 1, 2012

renameCollection appears to obtain both a write lock and global lock…wouldn't that block out the source collection being written to?

@epc
Copy link
Contributor Author

epc commented Oct 1, 2012

Also will the space requirements be the same as the existing db + indexes or potentially larger?

@tychoish tychoish merged commit 1071d77 into mongodb:master Oct 1, 2012
mongodb-server-docs-sync-bot bot pushed a commit that referenced this pull request May 22, 2025
#259)

* DOCSP-16529 Clarifies source/destination clusters on Quickstart

* Fixes per Ashley

* Fixes per Ashley

* Fixes per Ajay
mongodb-server-docs-sync-bot bot pushed a commit that referenced this pull request Jun 9, 2025
mongodb-server-docs-sync-bot bot pushed a commit that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants