Skip to content

Migrate splitting chunks - DOCS-304 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 30, 2012
Merged

Migrate splitting chunks - DOCS-304 #140

merged 9 commits into from
Aug 30, 2012

Conversation

a-leung
Copy link

@a-leung a-leung commented Aug 20, 2012

No description provided.

:term:`shard clusters <shard cluster>`. MongoDB automates these
processes; however, in some cases, particularly when you're setting up
a shard cluster, you may need to create and manipulate chunks
directly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-flowing these paragraphs makes reviewing more difficult.

avoid doing this unless you making a significant substantive change, otherwise it wastes time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 2nd line edited.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I see now.

I think asserting:

  1. That this document addresses one topic.
  2. MongoDB automates these tasks.

Is rhetorically confusing. The original isn't perfect by any means, but let's revert unless there's another good solution given that this is orthogonal to the project of getting the page redirected.

@tychoish
Copy link
Contributor

This patch set doesn't contain improvements to the documentation of the split database command, which is essential and would clear up one of the sections.

Also as an aside, talk to me in the morning about how best to proceed on this: I'm working on the command reference material in a way that will create an awful merge conflict so lets try and prevent that...

not contain the shard key, though it almost always makes sense to
that matches this query into two equal sized chunks.
The query in :func:`sh.splitFind()` may
not be based on the shard key, though it almost always makes sense to
query for the shard key in this case, and including the shard key will
expedite the operation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph no longer makes sense (the second sentence does not reflect the operation of MongoDB.) While the initial version is a bit verbose, I would revert and then delete/rewrite he redundant second sentence and leave the rest of the paragraph as is, which would resolve the issue without introducing a regression.

@tychoish
Copy link
Contributor

also we need to change :func: to :method:

@tychoish tychoish merged commit 519432a into mongodb:master Aug 30, 2012
mongo-cr-bot pushed a commit that referenced this pull request Dec 13, 2021
* DOCSP-20026 updates for update pt6

* Add mul

* Still in mul

* Add files

* Add files

* Add files

* Staging updates

* Review updates

* Staging tweaks
mongodb-server-docs-sync-bot bot pushed a commit that referenced this pull request May 22, 2025
* DOCSP-31028 Adds balancer warning

* Adds restart balancer message

* Fixes per Joe

* Fixes per Joe
mongodb-server-docs-sync-bot bot pushed a commit that referenced this pull request May 22, 2025
* Added empty stubs

* Split up content

* Fixed heading levels
mongodb-server-docs-sync-bot bot pushed a commit that referenced this pull request Jun 6, 2025
Configure site for Netlify roll out
mongodb-server-docs-sync-bot bot pushed a commit that referenced this pull request Jun 16, 2025
mongodb-server-docs-sync-bot bot pushed a commit that referenced this pull request Jun 24, 2025
mongodb-server-docs-sync-bot bot pushed a commit that referenced this pull request Jun 24, 2025
fix confluent sink connector link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants