-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Migrate splitting chunks - DOCS-304 #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
:term:`shard clusters <shard cluster>`. MongoDB automates these | ||
processes; however, in some cases, particularly when you're setting up | ||
a shard cluster, you may need to create and manipulate chunks | ||
directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-flowing these paragraphs makes reviewing more difficult.
avoid doing this unless you making a significant substantive change, otherwise it wastes time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 2nd line edited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I see now.
I think asserting:
- That this document addresses one topic.
- MongoDB automates these tasks.
Is rhetorically confusing. The original isn't perfect by any means, but let's revert unless there's another good solution given that this is orthogonal to the project of getting the page redirected.
This patch set doesn't contain improvements to the documentation of the Also as an aside, talk to me in the morning about how best to proceed on this: I'm working on the command reference material in a way that will create an awful merge conflict so lets try and prevent that... |
not contain the shard key, though it almost always makes sense to | ||
that matches this query into two equal sized chunks. | ||
The query in :func:`sh.splitFind()` may | ||
not be based on the shard key, though it almost always makes sense to | ||
query for the shard key in this case, and including the shard key will | ||
expedite the operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph no longer makes sense (the second sentence does not reflect the operation of MongoDB.) While the initial version is a bit verbose, I would revert and then delete/rewrite he redundant second sentence and leave the rest of the paragraph as is, which would resolve the issue without introducing a regression.
also we need to change :func: to :method: |
* DOCSP-20026 updates for update pt6 * Add mul * Still in mul * Add files * Add files * Add files * Staging updates * Review updates * Staging tweaks
* DOCSP-31028 Adds balancer warning * Adds restart balancer message * Fixes per Joe * Fixes per Joe
* Added empty stubs * Split up content * Fixed heading levels
Configure site for Netlify roll out
* (DOCSP-10959) Add sharded cluster support for Ops Manager
* DOCSP-18342: Source Connector Kafka topic config
fix confluent sink connector link
No description provided.