Skip to content

Commit ca6b350

Browse files
authored
[CXX] Do not initialize ENABLE_TESTS with the auto-downloaded C Driver (#135)
* enable tests change * typos * NR feedback * NR feedback
1 parent e57be7e commit ca6b350

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

source/upgrade.txt

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,12 @@ The v4.1 driver introduces the following breaking changes to the build system:
135135

136136
- Requires MongoDB C Driver v2.0.0 or later
137137

138+
.. _version-4.1-enable-tests-config:
139+
140+
- Sets the ``ENABLE_TESTS`` configuration option to ``OFF`` by default for
141+
auto-downloaded versions of the C driver. :ref:`This is an expansion of the
142+
change made in v4.0. <version-4.0-enable-tests-config>`
143+
138144
ABI Breaking Changes in v4.1
139145
````````````````````````````
140146
The v4.1 driver introduces the following breaking changes to the ABI:
@@ -145,7 +151,8 @@ The v4.1 driver introduces the following breaking changes to the ABI:
145151

146152
.. note::
147153

148-
This does not affect users who compile with C++17 or newer and have not set ``BSONCXX_POLY_USE_IMPLS=ON``
154+
This does not affect users who compile with C++17 or newer and have not set
155+
``BSONCXX_POLY_USE_IMPLS=ON``
149156

150157
.. _version-4.0-breaking-changes:
151158

@@ -170,11 +177,19 @@ The v4.0 driver introduces the following breaking changes to the build system:
170177
- Drops support for the ``MONGOCXX_OVERRIDE_DEFAULT_INSTALL_PREFIX`` configuration
171178
option. Default CMake behavior for ``CMAKE_INSTALL_PREFIX`` is now respected.
172179

180+
.. _version-4.0-enable-tests-config:
181+
173182
- Sets the ``ENABLE_TESTS`` configuration option to ``OFF`` by default. To
174183
re-enable building test targets, you must set ``ENABLE_TESTS`` to ``ON``.
175184
To include test targets in the "all" target, you must also set the
176185
``BUILD_TESTING`` option to ``ON``.
177186

187+
.. note::
188+
189+
This change does not apply to auto-downloaded versions of the
190+
C driver. :ref:`The change for auto-downloaded versions was added in
191+
v4.1. <version-4.1-enable-tests-config>`
192+
178193
.. _version-4.0-api-breaking:
179194

180195
API Breaking Changes in v4.0

source/whats-new.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,9 @@ The v4.1 driver release includes the following new features:
5050
- :manual:`Binary Data BSON Types </reference/bson-types/#binary-data>` in the {+mdb-server+} manual
5151
- :github:`BSON Binary Vector </mongodb/mongo-cxx-driver/blob/master/examples/bsoncxx/bson_binary_vector.cpp>` usage example on GitHub
5252
- Fixes the :ref:`C driver API version bug <v4.0-cmake-api-version-bug>` noted in the v4.0 release
53+
- Adds a change to the ``ENABLE_TESTS`` configuration default option that
54+
was originally announced for v4.0. For more information, see the :ref:`breaking
55+
change description <version-4.1-enable-tests-config>` on the Upgrade page.
5356

5457
To learn more about this release, see the
5558
`v4.1 Release Notes <https://github.com/mongodb/mongo-cxx-driver/releases/tag/r4.1.0>`__

0 commit comments

Comments
 (0)