Skip to content

DOCSP-48100: Consolidate minor versions #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented May 7, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48100

Staging Links

  • upgrade
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented May 7, 2025

    Deploy Preview for docs-php-library ready!

    Name Link
    🔨 Latest commit 62f8cca
    🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/681e239495ac500008558907
    😎 Deploy Preview https://deploy-preview-240--docs-php-library.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @rachel-mack rachel-mack left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm

    Copy link
    Member

    @alcaeus alcaeus left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Just a couple of suggestions regarding the naming of compatibility changes

    Version 2.0 Breaking Changes
    Version 2.x Breaking Changes
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    IMO, it makes sense to call these out as breaking changes in 2.0 - people will understand that these apply to future 2.x versions as well. This helps clarify that we don't make breaking changes in minor versions.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Fixed! I also added a sentence in the "Breaking Changes" introduction noting that only major version releases have breaking changes

    @@ -113,15 +113,15 @@ This library version introduces the following breaking changes:
    methods, you can register a :php:`CommandSubscriber
    <mongodb-driver-monitoring-commandsubscriber>` in your application.

    Version 1.20 Breaking Changes
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Version 1.x Breaking Changes
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    Version 1.x Breaking Changes
    Version 1.x Compatibility Changes

    We don't consider bumping dependencies such as minimum PHP or server versions as "breaking changes", as that would require us to only do these in a major version. The rationale is that for PHP versions, the compatibility is checked by composer, so users on a version of PHP that is no longer supported won't be upgraded to the newer driver version and thus don't encounter a breaking change. Since the server version drops are so far behind (one year after it's marked EOL by the server team), the number of people affected is fairly low. For example, we're only now dropping support for MongoDB 4.0.

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I see; I moved the compatibility changes to its own section to separate it from the breaking changes


    For library versions 1.19 and earlier, see the release notes and associated
    JIRA tickets for each release on `GitHub <https://github.com/mongodb/mongo-php-library/releases>`__.
    To view breaking changes for {+php-library+} versions 1.19 and earlier, see the
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    To view breaking changes for {+php-library+} versions 1.19 and earlier, see the
    To view compatibility changes for {+php-library+} versions 1.19 and earlier, see the

    @norareidy norareidy requested a review from alcaeus May 9, 2025 15:50
    @norareidy norareidy merged commit d84ef0a into mongodb:master May 15, 2025
    6 checks passed
    @norareidy norareidy deleted the DOCSP-48100-consolidate-versions branch May 15, 2025 14:51
    rustagir added a commit that referenced this pull request May 23, 2025
    * DOCSP-44581: v2 release (#234)
    
    * DOCSP-44581: v2 release
    
    * small fix
    
    * Add missing meta descriptions (#235)
    
    * Add missing meta descriptions
    
    * Apply suggestions from code review
    
    ---------
    
    Co-authored-by: Rachel Mackintosh <[email protected]>
    
    * DOCSP-48761: docker note (#237)
    
    * DOCSP-48100: Consolidate minor versions (#240)
    
    * DOCSP-48100: Consolidate minor versions
    
    * edits
    
    * remove old redirects
    
    * AB feedback
    
    * edit
    
    * DOCSP-48718-update-credentials (#247)
    
    * update username and password
    
    * misspelling
    
    * redirects
    
    * pre-standardization redirects
    
    * upgrade composer package vs
    
    * DOCSP-49150: bulkWrite docs + api (#250)
    
    * DOCSP-49150: bulkWrite docs + api
    
    * first pass fixes
    
    * JT PR fixes 1
    
    * upgrade composer package vs
    
    * JT PR fixes 2
    
    * small fix
    
    * JT PR fixes 3
    
    * remove reference to writeconcern option
    
    * add return values sections
    
    * object -> instance
    
    * NR PR fixes 1
    
    * returns -> throws
    
    * DOCSP-50022: remove eol server version mentions (#253)
    
    * DOCSP-50022: remove eol server version mentions
    
    * consolidate compat table rows
    
    * DOCSP-50155 - EOL MongoDB 4.0 (#252)
    
    * eol v4.0
    
    * update compat
    
    * DOCSP-50294: v2.1 release (#255)
    
    ---------
    
    Co-authored-by: Nick Larew <[email protected]>
    Co-authored-by: Rachel Mackintosh <[email protected]>
    Co-authored-by: Nora Reidy <[email protected]>
    Co-authored-by: shuangela <[email protected]>
    Co-authored-by: Mike Woofter <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants