DOCSP-44608: merge v2 into master #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOCSP-44239: v2 remove flags option
DOCSP-43953: v2 iterator changes
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jmikola
reviewed
Oct 24, 2024
| @@ -4,8 +4,6 @@ MongoDB\\Collection::dropSearchIndex() | |||
|
|
|||
| .. versionadded:: 1.17 | |||
|
|
|||
| .. default-domain:: mongodb | |||
There was a problem hiding this comment.
I have no idea what this is used for, but isn't it included in many more pages within the PHPLIB docs? Or is this PR actually removing all references?
There was a problem hiding this comment.
I've only removed this from the pages that I've touched in this PR to avoid cluttering the "Files Changed"
There was a problem hiding this comment.
If it's not actually related to this PR would it make sense to do another that removes it everywhere in one shot?
There was a problem hiding this comment.
I can do that after merging this, sure!
jmikola
approved these changes
Oct 25, 2024
source/whats-new.txt
Outdated
| @@ -65,7 +65,7 @@ improvements, and fixes: | |||
|
|
|||
| - The fields ``contentType`` and ``aliases`` are no longer stored in | |||
| the ``files`` GridFS collection. If your application requires this | |||
| information, you must store it in metadata. To learn mor about | |||
| information, you must store it in metadata. To learn More about | |||
There was a problem hiding this comment.
Suggested change
| information, you must store it in metadata. To learn More about | |
| information, you must store it in metadata. To learn more about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44608
Staging - https://deploy-preview-174--docs-php-library.netlify.app/whats-new/#what-s-new-in-2.0
Self-Review Checklist