INTPYTHON-658 Add PolymorphicEmbeddedModelArrayField #335
+523
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
polymorphic-array
branch
from
729fd87 to
d348536
Compare
WaVEV
reviewed
Jul 16, 2025
| super().contribute_to_class(cls, name, private_only=private_only, **kwargs) | ||
|
|
||
| if not cls._meta.abstract: | ||
| # If the embedded_model argument is a string, resolve it to the |
There was a problem hiding this comment.
If the embedded_models is a list of string...
or it is an string?
WaVEV
reviewed
Jul 16, 2025
| def test_array_slice(self): | ||
| self.assertSequenceEqual(Owner.objects.filter(pets__0_1__name="Woofer"), [self.fred]) | ||
|
|
||
| # def test_filter_unsupported_lookups_in_json(self): |
There was a problem hiding this comment.
is this test a valid test or shouldn't be considered?
There was a problem hiding this comment.
Given that transform is almost the same, it will work in the same way. So, it is already tested.
There was a problem hiding this comment.
All of the commented tests are copied from EmbeddedModelArrayField tests. I don't think they need to be re-implemented here, but I left them for your opinion.
There was a problem hiding this comment.
The transform.get_transform is the same, the lookups will work in the same way. So, they aren't needed and the lookups are also registered.
timgraham
force-pushed
the
polymorphic-array
branch
from
d348536 to
e9ae1a5
Compare
WaVEV
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: