Skip to content

INTPYTHON-575 Fix handling of empty embedded arrays #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 requested a review from aclark4life April 22, 2025 13:41
@blink1073 blink1073 requested a review from a team as a code owner April 22, 2025 13:41
Copy link
Contributor

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -75,7 +75,7 @@ def _parse_builder_map(builder_map):
elif value.type_marker == _BsonArrowTypes.array.value:
child_name = key + "[]"
to_remove.append(child_name)
child = builder_map[child_name]
child = builder_map.get(child_name, [])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just this? Cool.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@blink1073 blink1073 merged commit a984af8 into mongodb-labs:main Apr 22, 2025
42 of 43 checks passed
@blink1073 blink1073 deleted the INTPYTHON-575 branch April 22, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants