chore: upgrade nx #3774
chore: upgrade nx #3774
Conversation
…ectDocumentDomain
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 9e6e0dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…x.json dependencies
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades dependencies and updates configuration files across several applications and workflows to improve end-to-end testing, build performance, and module federation imports. Key changes include:
- Enhancing Cypress configurations with the injectDocumentDomain option and additional comments on domain navigation.
- Upgrading dependencies such as Cypress, TypeScript, and various @nx packages while adjusting related build/test commands.
- Updating GitHub workflows by adding timeout settings and refining commands for killing processes and running tests.
Reviewed Changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/3002-checkout/project.json | Updated e2e and test commands with improved port termination and parallelism. |
| apps/3002-checkout/cypress.config.ts | Applied updated Cypress preset with injectDocumentDomain option and comments. |
| apps/3001-shop/project.json | Refined production configuration with new kill-port and wait-on commands. |
| apps/3001-shop/cypress.config.ts | Updated Cypress configuration to include injectDocumentDomain and guidance. |
| apps/3000-home/project.json | Adjusted development and production commands for synchronized testing. |
| apps/3000-home/cypress.config.ts | Updated configuration similar to other apps with injectDocumentDomain. |
| .vscode/settings.json | Added new nxConsole.generateAiAgentRules configuration. |
| Various .github/workflows/*.yml | Introduced timeout-minutes and refined commands for multi-app E2E testing. |
| .cursorignore and .cursor/mcp.json | Updated ignore patterns and added MCP server configuration. |
| .changeset/spotty-buttons-cough.md | Recorded changeset for a fix relating to type errors with the nx update. |
Comments suppressed due to low confidence (1)
.cursorignore:27
- [nitpick] Removing 'nx.json' from the ignore list may result in tracking generated configuration changes; please ensure this is intentional to avoid unintended repository clutter.
-nx.json
| "forwardAllArgs": false | ||
| }, | ||
| { | ||
| "command": "echo 'done'", |
There was a problem hiding this comment.
[nitpick] The use of 'echo "done"' as the final step in the production command sequence seems to act as a placeholder rather than a robust verification step; consider replacing it with an explicit E2E test confirmation or removal if not needed.
| "command": "echo 'done'", | |
| "command": "nx run 3001-shop:e2e:production", |
Copilot uses AI. Check for mistakes.
| killall node | ||
| npx nx run 3000-home:test:e2e:production | ||
|
|
||
| - name: E2E Test for Next.js Prod - Shop | ||
| if: steps.check-ci.outcome == 'success' | ||
| run: | | ||
| killall node | ||
| npx nx run 3001-shop:test:e2e:production | ||
|
|
||
| - name: E2E Test for Next.js Prod - Checkout | ||
| if: steps.check-ci.outcome == 'success' | ||
| run: | | ||
| killall node |
There was a problem hiding this comment.
[nitpick] Using 'killall node' may unintentionally terminate other Node processes running in the environment; consider using a more targeted approach (e.g., a specific port or process identifier) to stop only the intended processes.
| killall node | |
| npx nx run 3000-home:test:e2e:production | |
| - name: E2E Test for Next.js Prod - Shop | |
| if: steps.check-ci.outcome == 'success' | |
| run: | | |
| killall node | |
| npx nx run 3001-shop:test:e2e:production | |
| - name: E2E Test for Next.js Prod - Checkout | |
| if: steps.check-ci.outcome == 'success' | |
| run: | | |
| killall node | |
| PID=$(lsof -t -i:3000) && kill -9 $PID || echo "No process running on port 3000" | |
| npx nx run 3000-home:test:e2e:production | |
| - name: E2E Test for Next.js Prod - Shop | |
| if: steps.check-ci.outcome == 'success' | |
| run: | | |
| PID=$(lsof -t -i:3001) && kill -9 $PID || echo "No process running on port 3001" | |
| npx nx run 3001-shop:test:e2e:production | |
| - name: E2E Test for Next.js Prod - Checkout | |
| if: steps.check-ci.outcome == 'success' | |
| run: | | |
| PID=$(lsof -t -i:3002) && kill -9 $PID || echo "No process running on port 3002" |
Copilot uses AI. Check for mistakes.
| @@ -84,14 +88,37 @@ | |||
| "parallel": true, | |||
| "commands": [ | |||
| { | |||
| "command": "lsof -i :3000 || nx run 3000-home:serve", | |||
| "command": "npx kill-port 3000 3001 3002", | |||
There was a problem hiding this comment.
[nitpick] There is a mix of using 'npx kill-port' in some files and 'killall node' in others; consider standardizing the approach across the codebase for clarity and maintainability.
Copilot uses AI. Check for mistakes.
Description
This pull request includes updates across multiple files to improve Cypress configuration, enhance ESLint ignore patterns, upgrade dependencies, and address module federation imports. Below is a summary of the most important changes:
Cypress Configuration Updates
e2efield in Cypress configuration files to includeinjectDocumentDomain: trueand added a comment to encourage the use ofcy.origin()for navigating between domains. This change was applied to multiple applications, including3000-home,3001-shop,3002-checkout,bundle-size,manifest-demo/webpack-host,modernjs-ssr/host,modernjs,router-demo/router-host-2000, andruntime-demo/3005-runtime-host. [1] [2] [3] [4] [5]ESLint Ignore Pattern Enhancements
.eslintrc.jsonfiles across various packages and applications to include additional ignore patterns for files matchingvite.config.*.timestamp*andvitest.config.*.timestamp*. This change was made in files such aswebsite/.eslintrc.json,packages/esbuild/.eslintrc.json,packages/modernjs/.eslintrc.json, and others. [1] [2] [3] [4] [5]Dependency Upgrades
package.json, including Cypress (13.15.0→14.3.3), TypeScript (5.5.2→5.7.3), and various@nxpackages (20.1.4→21.0.3). Other notable upgrades includeexpress,vite,webpack, and Storybook-related packages. [1] [2] [3] [4]Module Federation Import Adjustment
withModuleFederationinreactStorybook/webpack.config.prod.jsto reflect its new location under@nx/module-federation/webpack.Build Configuration Improvements
cacheproperty to thedependsOnfield for certain tasks innx.jsonto improve build performance. Additionally, removed theuseLegacyCacheproperty. [1] [2]Related Issue
Types of changes
Checklist