Skip to content

RNN-T constants #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 13, 2021
Merged

RNN-T constants #84

merged 22 commits into from
Apr 13, 2021

Conversation

mwawrzos
Copy link
Contributor

@mwawrzos mwawrzos commented Feb 9, 2021

  1. Changes in mlperf_logging/mllog/constants.py reflect recent rules in https://github.com/mlcommons/training_policies/blob/47e08397ac6dd46a940816c65bd291a9d218383f/training_rules.adoc#91-hyperparameters
  2. mlperf_logging/compliance_checker/1.0.0/closed_rnnt.yaml had to be updated after changes in 1.

@github-actions
Copy link

github-actions bot commented Feb 9, 2021

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@mwawrzos
Copy link
Contributor Author

recheck

@mwawrzos
Copy link
Contributor Author

@xyhuang I made the changes you proposed at the last logging meeting:

  1. I have rewritten the checks to validate based on metadata here: aa44366
    An example of reporting such entry is here: https://github.com/mlcommons/training/blob/66d6c2dc784ff5b15641807a65036ffedd68af83/rnn_speech_recognition/pytorch/rnnt/model.py#L131-L132
  2. I also worked with Michał to add Unet3D checks here in the v1.0.0 directory.
  3. I moved the RNN-T constants update to RNN-T constants #84 to make this PR independent from RNN-T hyperparamters training_policies#425

Is it possible to merge this PR?

@mwawrzos mwawrzos requested a review from xyhuang March 11, 2021 14:08
@mwawrzos
Copy link
Contributor Author

@xyhuang , hyperparameter names are accepted in mlcommons/training_policies#425
Can we merge this PR now?

@xyhuang xyhuang merged commit 0bb3957 into mlcommons:master Apr 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants