Set card link on org dashboard pages to courseware url #2239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAPI ChangesShow/hide No detectable change.Unexpected changes? Ensure your branch is up-to-date with |
jonkafton
reviewed
May 9, 2025
| @@ -153,6 +153,8 @@ const OrgProgramDisplay: React.FC<{ | |||
| dashboardResource={course} | |||
| courseNoun="Module" | |||
| offerUpgrade={false} | |||
| titleHref={course.run.coursewareUrl} | |||
There was a problem hiding this comment.
Though it's assumed the course from the API will always have a run and while we're typing locally in anticipation of the programs list API, could we add an optional chaining guard here just in case, ie. course.run?.coursewareUrl.
jonkafton
approved these changes
May 9, 2025
…them both to the coursewareUrl on org pages
gumaerc
force-pushed
the
cg/org-page-courseware-url-title-and-button
branch
from
5b3f8a0 to
2d3ea59
Compare
This was referenced May 16, 2025
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/7255
Description (What does it do?)
This PR alters
DashboardCardto allow optionally specifying a URL for either the title or button. On organization dashboard pages, the title link is set to the same courseware URL that the button is set to, as requested in the above issue.How can this be tested?
mit-learnenrollment-dashboardandmitlearn-organization-dashboardfeature flags