Skip to content

Drawer/chat accessibility fixes #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 25, 2025
Merged

Drawer/chat accessibility fixes #2214

merged 6 commits into from
Apr 25, 2025

Conversation

jonkafton
Copy link
Contributor

@jonkafton jonkafton commented Apr 24, 2025

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/7082

Description (What does it do?)

Addresses the competing close buttons on the syllabus drawer with a rotating chevron for slide down/up.

Upgrades Smoot Design for:

mitodl/smoot-design#92

  • Chat prompt input should receive focus after submit from entry screen (text inut and starters buttons).
  • High: Entry screen conversation starter buttons should have a natural tab order (tabindex: 0).
  • High: Entry screen prompt submit needs a label for screen readers.
  • Entry screen prompt input should have more prominent focus styles (match blue border on starts buttons).
  • Add structure and mechanisms to navigate the messages thread for screen readers.

mitodl/smoot-design#93

  • fix: Remove double indent for chat message ordered lists

Adds a requestAnimationFrame to wait for first render before scrolling to the top - fixes an issue where the drawer opened with content scrolled to bottom.

Screenshots (if appropriate):

Screen.Recording.2025-04-24.at.17.57.02.mov

How can this be tested?

You'll need to set chatEnabled to true in LearningResourceExpanded.tsx to bypass the Posthog setting. Open the drawer on a course and open/close the AskTIM slidedown.

Additional Context

We've pulled out the drawer limited content at zoom item as designs are in flight and it's covered by an earlier ticket (https://github.com/mitodl/hq/issues/6513). This branch captures the wip design.

  • High: The syllabus drawer messages thread needs more space at page zoom magnification - the drawer header area limits space further). At 200% only a couple of lines are visible. At 300% it is obscured completely.

Copy link

OpenAPI Changes

Show/hide No detectable change.

@jonkafton jonkafton added the Needs Review An open Pull Request that is ready for review label Apr 24, 2025
@gumaerc gumaerc self-assigned this Apr 25, 2025
Copy link
Contributor

@gumaerc gumaerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonkafton jonkafton removed the Needs Review An open Pull Request that is ready for review label Apr 25, 2025
Copy link

OpenAPI Changes

Show/hide No detectable change.

@jonkafton jonkafton merged commit 0b72b05 into main Apr 25, 2025
12 checks passed
@jonkafton jonkafton deleted the jk/7082-accessibility branch April 25, 2025 19:09
This was referenced May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants