Skip to content

fix: deployment variable, add comma between build args #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

ChristopherChudzicki
Copy link
Contributor

What are the relevant tickets?

None

Description (What does it do?)

This adds a comma between two build args in the deployment github actions

How can this be tested?

Test on RC.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ChristopherChudzicki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request adds a comma between build arguments in the deployment GitHub Actions workflows for both production and release candidate environments. This ensures that the environment variables are correctly passed during the build process.

Highlights

  • Bug fix: A missing comma was added to the production.yml file to ensure correct parsing of environment variables during the build process.
  • Bug fix: A missing comma was added to the release-candidate.yml file to ensure correct parsing of environment variables during the build process.

Changelog

  • .github/workflows/production.yml
    • Added a comma after NEXT_PUBLIC_VERSION=$VERSION on line 87 to separate it from the subsequent environment variable.
  • .github/workflows/release-candidate.yml
    • Added a comma after NEXT_PUBLIC_VERSION=$VERSION on line 87 to separate it from the subsequent environment variable.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Trivia time!

What is YAML an acronym for?

Click here for the answer
YAML Ain't Markup Language

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a comma between build arguments in the deployment GitHub Actions workflows. The change is straightforward and addresses a potential issue where the lack of a comma could lead to incorrect environment variable configuration.

Summary of Findings

Merge Readiness

The pull request is a small but important fix. The addition of the comma ensures that the environment variables are correctly passed to the build process. Given the straightforward nature of the change and the potential impact of the missing comma, I recommend merging this pull request after verifying the change on RC as suggested. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

@ChristopherChudzicki ChristopherChudzicki marked this pull request as ready for review February 28, 2025 14:58
@ChristopherChudzicki ChristopherChudzicki changed the title Add comma between build args fix deployment variable: Add comma between build args Feb 28, 2025
@ChristopherChudzicki ChristopherChudzicki changed the title fix deployment variable: Add comma between build args fix: deployment variable, add comma between build args Feb 28, 2025
@ChristopherChudzicki ChristopherChudzicki mentioned this pull request Feb 28, 2025
15 tasks
@ChristopherChudzicki ChristopherChudzicki merged commit 6862b2b into main Feb 28, 2025
10 of 11 checks passed
@ChristopherChudzicki ChristopherChudzicki deleted the cc/fix-logout-suffix-action-var branch February 28, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants