Skip to content

add MITOL_LOGOUT_SUFFIX to github actions #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

ChristopherChudzicki
Copy link
Contributor

What are the relevant tickets?

None

Description (What does it do?)

Logout is currently broken on RC due to missing env. This PR, together with mitodl/ol-infrastructure#2983, should fix it.

How can this be tested?

Will need to test on RC.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ChristopherChudzicki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request adds the MITOL_API_LOGOUT_SUFFIX environment variable to the Github Actions workflows for both production and release candidate environments. This is intended to fix a broken logout functionality on the Release Candidate environment. The changes involve modifying the production.yml and release-candidate.yml files to include the new environment variable and its corresponding secret.

Highlights

  • Environment Variable Addition: The MITOL_API_LOGOUT_SUFFIX environment variable is added to the workflow environment variables in both production.yml and release-candidate.yml.
  • Secret Integration: The value for MITOL_API_LOGOUT_SUFFIX is sourced from the corresponding environment secrets (MITOL_API_LOGOUT_SUFFIX_PROD and MITOL_API_LOGOUT_SUFFIX_RC).
  • Logout Fix: This change, along with a related pull request in the ol-infrastructure repository, aims to resolve a broken logout functionality on the Release Candidate environment.

Changelog

  • .github/workflows/production.yml
    • Added MITOL_API_LOGOUT_SUFFIX to the environment variables in the jobs section, using the MITOL_API_LOGOUT_SUFFIX_PROD secret (line 64).
    • Added NEXT_PUBLIC_MITOL_API_LOGOUT_SUFFIX to the environment variables passed to the frontend build process (line 88).
  • .github/workflows/release-candidate.yml
    • Added MITOL_API_LOGOUT_SUFFIX to the environment variables in the jobs section, using the MITOL_API_LOGOUT_SUFFIX_RC secret (line 64).
    • Added NEXT_PUBLIC_MITOL_API_LOGOUT_SUFFIX to the environment variables passed to the frontend build process (line 88).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Trivia time!

What is the purpose of environment variables in software development?

Click here for the answer
Environment variables are dynamic-named values that can affect the way running processes will behave on a computer. They are part of the environment in which a process runs. They can be used to configure software without changing its code.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ChristopherChudzicki ChristopherChudzicki marked this pull request as ready for review February 27, 2025 19:56
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the MITOL_API_LOGOUT_SUFFIX environment variable to the GitHub Actions workflows for both production and release candidate environments. This change aims to fix a broken logout functionality on the RC environment. The addition of this variable ensures that the correct logout suffix is used when constructing logout URLs, particularly in environments using Keycloak.

Summary of Findings

Merge Readiness

The pull request appears to address a specific issue with logout functionality in the RC environment. The changes are straightforward and seem necessary for the correct operation of the application. Given the context provided, I recommend merging this pull request after testing on the RC environment, as indicated in the PR description. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.

@ChristopherChudzicki ChristopherChudzicki merged commit 01fc6b6 into main Feb 27, 2025
11 checks passed
@ChristopherChudzicki ChristopherChudzicki deleted the cc/update-actions-for-apisix branch February 27, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants