Skip to content

Simplify Theme #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Simplify Theme #1870

merged 4 commits into from
Dec 5, 2024

Conversation

ChristopherChudzicki
Copy link
Contributor

What are the relevant tickets?

Related to https://github.com/mitodl/hq/issues/6039

Description (What does it do?)

This PR removes some unused global CSS and theme customizations.

How can this be tested?

  1. Visit various pages in the app. There should be no visible changes.

Additional Context

I removed things one commit at a time with comments in the commits. Everything is very clearly unused, except 86f35f6—the absence of HTML select elements is a bit less obvious.

We have no elements with id #app-container
We do not use DialogContent, except in deprecated ManageWidgetDialog.tsx
@ChristopherChudzicki ChristopherChudzicki marked this pull request as ready for review December 3, 2024 20:40
@ChristopherChudzicki ChristopherChudzicki changed the title Cc/simplify theme Simplify Theme Dec 3, 2024
@ChristopherChudzicki ChristopherChudzicki added the Needs Review An open Pull Request that is ready for review label Dec 4, 2024
@shanbady shanbady self-assigned this Dec 5, 2024
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. 👍

@shanbady shanbady added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Dec 5, 2024
@ChristopherChudzicki ChristopherChudzicki merged commit 70057a0 into main Dec 5, 2024
11 checks passed
@odlbot odlbot mentioned this pull request Dec 9, 2024
15 tasks
@rhysyngsun rhysyngsun deleted the cc/simplify-theme branch February 7, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants