Remove some unused exports from ol-components #1844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkafton
approved these changes
Nov 22, 2024
Comment on lines
+10
to
+17
| const ErrorContainer = styled(Container)(({ theme }) => ({ | ||
| backgroundColor: theme.custom.colors.white, | ||
| borderRadius: "8px", | ||
| marginTop: "4rem", | ||
| padding: "16px", | ||
| boxShadow: | ||
| "1px 2px 1px -1px rgba(0,0,0,0.2),0px 1px 1px 0px rgba(0,0,0,0.14),0px 1px 3px 0px rgba(0,0,0,0.12)", | ||
| })) |
There was a problem hiding this comment.
Are these part of the design system and could be their own component / card variant or are they left over from before the Smoot treatment or just default Mui styles?
The error page and no search results may be the only instances.
There was a problem hiding this comment.
The box shadow there is a style from MuiCard.
Rather than importing MuiCard in main, I just copied the boxshadow to preserve the existing behavior.
| </Stack> | ||
| {channel.data ? <ChannelDetails channel={channel.data} /> : null} | ||
| </BannerContent> | ||
| </Container> | ||
| </StyledBannerBackground> | ||
| <Container component="section"> | ||
| <Container id="foo" component="section"> |
There was a problem hiding this comment.
yep. Oops
mbertrand
pushed a commit
that referenced
this pull request
Dec 2, 2024
* chore: remove unused exports * remove muidialog from ol-components * remove box usage * remove mui cards * fix a test * remove testing id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
For https://github.com/mitodl/hq/issues/6039
Description (What does it do?)
This cleans up
ol-componentsmui re-exports a bit:MuiCardand friends. This is still used inol-widgets, where it's just imported from mui directly.How can this be tested?
/c/unit/ocwor any other channel page. The subscribe button should be in same spot./search?q=gdjslkghafkaghafdklhdafsbkthe "Not found" card should look the same/kjgoidshthe "Not Found" error page should look the same.