Add data-ph- elements to CTA buttons (#1821)

jkachel · web-flow · commit 2942facd3e3a · 2024-11-13T10:34:20.000-06:00
diff --git a/frontends/ol-components/src/components/LearningResourceExpanded/LearningResourceExpandedV1.test.tsx b/frontends/ol-components/src/components/LearningResourceExpanded/LearningResourceExpandedV1.test.tsx
@@ -104,6 +104,7 @@ describe("Learning Resource Expanded", () => {
         }) as HTMLAnchorElement
 
         expect(link.href).toMatch(new RegExp(`^${resource.url}/?$`))
+        expect(link.getAttribute("data-ph-action")).toBe("click-cta")
       }
     },
   )
diff --git a/frontends/ol-components/src/components/LearningResourceExpanded/LearningResourceExpandedV1.tsx b/frontends/ol-components/src/components/LearningResourceExpanded/LearningResourceExpandedV1.tsx
@@ -244,6 +244,10 @@ const CallToActionSection = ({
       <StyledLink
         target="_blank"
         size="medium"
+        data-ph-action="click-cta"
+        data-ph-offered-by={offeredBy?.code}
+        data-ph-resource-type={resource.resource_type}
+        data-ph-resource-id={resource.id}
         endIcon={<RiExternalLinkLine />}
         href={getCallToActionUrl(resource) || ""}
       >
diff --git a/frontends/ol-components/src/components/LearningResourceExpanded/LearningResourceExpandedV2.test.tsx b/frontends/ol-components/src/components/LearningResourceExpanded/LearningResourceExpandedV2.test.tsx
@@ -105,6 +105,7 @@ describe("Learning Resource Expanded", () => {
         }) as HTMLAnchorElement
 
         expect(link.href).toMatch(new RegExp(`^${resource.url}/?$`))
+        expect(link.getAttribute("data-ph-action")).toBe("click-cta")
       }
     },
   )
diff --git a/frontends/ol-components/src/components/LearningResourceExpanded/LearningResourceExpandedV2.tsx b/frontends/ol-components/src/components/LearningResourceExpanded/LearningResourceExpandedV2.tsx
@@ -355,6 +355,10 @@ const CallToActionSection = ({
       <StyledLink
         target="_blank"
         size="medium"
+        data-ph-action="click-cta"
+        data-ph-offered-by={offeredBy?.code}
+        data-ph-resource-type={resource.resource_type}
+        data-ph-resource-id={resource.id}
         endIcon={<RiExternalLinkLine />}
         href={getCallToActionUrl(resource) || ""}
       >

Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,7 @@ describe("Learning Resource Expanded", () => {`
`104`	`104`	`}) as HTMLAnchorElement`
`105`	`105`
`106`	`106`	expect(link.href).toMatch(new RegExp(`^${resource.url}/?$`))
	`107`	`+ expect(link.getAttribute("data-ph-action")).toBe("click-cta")`
`107`	`108`	`}`
`108`	`109`	`},`
`109`	`110`	`)`
Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,7 @@ describe("Learning Resource Expanded", () => {`
`105`	`105`	`}) as HTMLAnchorElement`
`106`	`106`
`107`	`107`	expect(link.href).toMatch(new RegExp(`^${resource.url}/?$`))
	`108`	`+ expect(link.getAttribute("data-ph-action")).toBe("click-cta")`
`108`	`109`	`}`
`109`	`110`	`},`
`110`	`111`	`)`