Refactor mintscript tests - put the expected output directly into the code #1934
+393
−286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current tests in
mintscript
are rather hard to maintain because the expected values are in separate files with not very descriptive names.In this PR I've put the expected values directly into the code and removed the files.
The tests can still be improved though (e.g. it'd be better if the expected values were Rust objects instead of their string representations), I've left a TODO about it.
Edit:
input_commitments::order_fill
test in the chainstate test suite, due to a low initial amount being generated (not enough to do 2 fills), I fixed it here by increasing the amounts and also did the same in another similar test.