Merge pull request #1970 from mintlayer/partially_signed_tx_in_wasm_wrappers

Partially signed tx in wasm wrappers

Author: ImplOfAnImpl

Cargo.lock

@@ -16,6 +16,7 @@
 use std::convert::Infallible;
 
 use common::chain::{
+    partially_signed_transaction::PartiallySignedTransaction,
     signature::{
         inputsig::InputWitness, sighash::input_commitments::SighashInputCommitment,
         DestinationSigError, Transactable,
@@ -104,6 +105,7 @@ impl<T: Transactable> InputInfoProvider for InputVerifyContextSignature<'_, T> {
 // Prevent BlockRewardTransactable from being used here
 pub trait SignatureOnlyVerifiable {}
 impl SignatureOnlyVerifiable for SignedTransaction {}
+impl SignatureOnlyVerifiable for PartiallySignedTransaction {}
 
 // Note: the passed `outpoint_destination` value is only used in a limited number of scenarios
 // (see `impl SignatureInfoProvider for InputVerifyContextSignature` above). In all other cases

chainstate/tx-verifier/src/transaction_verifier/input_check/signature_only_check.rs

@@ -18,6 +18,7 @@ pub mod chaintrust;
 pub mod config;
 pub mod gen_block;
 pub mod genesis;
+pub mod partially_signed_transaction;
 pub mod tokens;
 pub mod transaction;
 

common/src/chain/mod.rs

@@ -0,0 +1,149 @@
+// Copyright (c) 2021-2025 RBB S.r.l
+// [email protected]
+// SPDX-License-Identifier: MIT
+// Licensed under the MIT License;
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// https://github.com/mintlayer/mintlayer-core/blob/master/LICENSE
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use std::collections::BTreeMap;
+
+use serialization::{Decode, Encode};
+
+use crate::{
+    chain::{
+        output_value::OutputValue,
+        signature::sighash::{self},
+        OrderId, PoolId,
+    },
+    primitives::Amount,
+};
+
+// Note: PoolAdditionalInfo and OrderAdditionalInfo below are identical to the corresponding
+// structs in `input_commitments/info_providers.rs` (except that those don't derive Encode/Decode)
+// and basically serve the same purpose.
+// We keep them separate because:
+// 1) Technically we may want to have even more info inside partially signed transaction in
+// the future, which may not be needed by the input commitments.
+// 2) We want to be able to refactor input commitments structs without worrying about breaking
+// PartiallySignedTransaction's backward compatibility.
+
+/// Pool additional info, which must be present for each ProduceBlockFromStake UTXO consumed by
+/// the transaction. Transaction's signature commits to this info since SighashInputCommitments::V1.
+#[derive(Debug, Eq, PartialEq, Clone, Encode, Decode, serde::Serialize)]
+pub struct PoolAdditionalInfo {
+    pub staker_balance: Amount,
+}
+
+/// Order additional info, which must be present for each FillOrder and ConcludeOrder input consumed
+/// by the transaction. Transaction's signature commits to this info since SighashInputCommitments::V1.
+///
+/// Note though that only ConcludeOrder commitments include both initial and current balances,
+/// while FillOrder commitments only include the initial ones. So this info representation
+/// is not ideal, as it forces the caller to provide additional info that will not actually
+/// be used.
+#[derive(Debug, Eq, PartialEq, Clone, Encode, Decode, serde::Serialize)]
+pub struct OrderAdditionalInfo {
+    pub initially_asked: OutputValue,
+    pub initially_given: OutputValue,
+    pub ask_balance: Amount,
+    pub give_balance: Amount,
+}
+
+#[derive(Debug, Eq, PartialEq, Clone, Encode, Decode, serde::Serialize)]
+pub struct TxAdditionalInfo {
+    pool_info: BTreeMap<PoolId, PoolAdditionalInfo>,
+    order_info: BTreeMap<OrderId, OrderAdditionalInfo>,
+}
+
+impl TxAdditionalInfo {
+    pub fn new() -> Self {
+        Self {
+            pool_info: BTreeMap::new(),
+            order_info: BTreeMap::new(),
+        }
+    }
+
+    pub fn with_pool_info(mut self, pool_id: PoolId, info: PoolAdditionalInfo) -> Self {
+        self.pool_info.insert(pool_id, info);
+        self
+    }
+
+    pub fn with_order_info(mut self, order_id: OrderId, info: OrderAdditionalInfo) -> Self {
+        self.order_info.insert(order_id, info);
+        self
+    }
+
+    pub fn add_pool_info(&mut self, pool_id: PoolId, info: PoolAdditionalInfo) {
+        self.pool_info.insert(pool_id, info);
+    }
+
+    pub fn add_order_info(&mut self, order_id: OrderId, info: OrderAdditionalInfo) {
+        self.order_info.insert(order_id, info);
+    }
+
+    pub fn join(mut self, other: Self) -> Self {
+        self.pool_info.extend(other.pool_info);
+        self.order_info.extend(other.order_info);
+        Self {
+            pool_info: self.pool_info,
+            order_info: self.order_info,
+        }
+    }
+
+    pub fn get_pool_info(&self, pool_id: &PoolId) -> Option<&PoolAdditionalInfo> {
+        self.pool_info.get(pool_id)
+    }
+
+    pub fn get_order_info(&self, order_id: &OrderId) -> Option<&OrderAdditionalInfo> {
+        self.order_info.get(order_id)
+    }
+
+    pub fn pool_info_iter(&self) -> impl Iterator<Item = (&'_ PoolId, &'_ PoolAdditionalInfo)> {
+        self.pool_info.iter()
+    }
+
+    pub fn order_info_iter(&self) -> impl Iterator<Item = (&'_ OrderId, &'_ OrderAdditionalInfo)> {
+        self.order_info.iter()
+    }
+}
+
+impl sighash::input_commitments::PoolInfoProvider for TxAdditionalInfo {
+    type Error = std::convert::Infallible;
+
+    fn get_pool_info(
+        &self,
+        pool_id: &PoolId,
+    ) -> Result<Option<sighash::input_commitments::PoolInfo>, Self::Error> {
+        Ok(
+            self.pool_info.get(pool_id).map(|info| sighash::input_commitments::PoolInfo {
+                staker_balance: info.staker_balance,
+            }),
+        )
+    }
+}
+
+impl sighash::input_commitments::OrderInfoProvider for TxAdditionalInfo {
+    type Error = std::convert::Infallible;
+
+    fn get_order_info(
+        &self,
+        order_id: &OrderId,
+    ) -> Result<Option<sighash::input_commitments::OrderInfo>, Self::Error> {
+        Ok(
+            self.order_info.get(order_id).map(|info| sighash::input_commitments::OrderInfo {
+                initially_asked: info.initially_asked.clone(),
+                initially_given: info.initially_given.clone(),
+                ask_balance: info.ask_balance,
+                give_balance: info.give_balance,
+            }),
+        )
+    }
+}