Skip to content

Commit ac298b8

Browse files
committed
fix bug when bucket name along changes in route with kbar
1 parent 1ad4bf2 commit ac298b8

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

portal-ui/src/screens/Console/Buckets/BucketDetails/BrowserHandler.tsx

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,16 @@ const BrowserHandler = () => {
293293
[bucketName, rewindEnabled, showDeleted, dispatch, onMessageCallBack]
294294
);
295295

296+
useEffect(() => {
297+
// when a bucket param changes, (i.e /browser/:bucketName), re-init e.g with KBar
298+
if (bucketName) {
299+
dispatch(resetMessages());
300+
dispatch(setLoadingRecords(true));
301+
dispatch(setLoadingObjects(true));
302+
initWSRequest("", new Date());
303+
}
304+
}, [bucketName, dispatch]);
305+
296306
useEffect(() => {
297307
return () => {
298308
const request: WebsocketRequest = {
@@ -332,7 +342,7 @@ const BrowserHandler = () => {
332342
)
333343
);
334344
}
335-
}, [internalPaths, rewindDate, rewindEnabled, dispatch]);
345+
}, [bucketName, internalPaths, rewindDate, rewindEnabled, dispatch]);
336346

337347
// Direct file access effect / prefix
338348
useEffect(() => {

portal-ui/src/screens/Console/ObjectBrowser/OBBucketList.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ import {
5757
} from "../../../api/consoleApi";
5858
import { api } from "../../../api";
5959
import { errorToHandler } from "../../../api/errors";
60-
import { setLoadingObjects, setShowDeletedObjects } from "./objectBrowserSlice";
60+
import { setLoadingObjects } from "./objectBrowserSlice";
6161

6262
const useStyles = makeStyles((theme: Theme) =>
6363
createStyles({
@@ -133,7 +133,6 @@ const OBListBuckets = () => {
133133
{
134134
type: "view",
135135
onClick: (bucket: Bucket) => {
136-
dispatch(setShowDeletedObjects(false)); //reset whenever bucket changes
137136
navigate(`${IAM_PAGES.OBJECT_BROWSER_VIEW}/${bucket.name}`);
138137
},
139138
},

0 commit comments

Comments
 (0)