Skip to content

Commit a5175a3

Browse files
authored
Use swagger api for import KSM Key (#3204)
1 parent d9f945b commit a5175a3

File tree

6 files changed

+28
-22
lines changed

6 files changed

+28
-22
lines changed

web-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
"customize-cra": "^1.0.0",
8282
"minio": "^7.1.3",
8383
"nyc": "^15.1.0",
84-
"prettier": "3.1.1",
84+
"prettier": "3.2.4",
8585
"react-app-rewire-hot-loader": "^2.0.1",
8686
"react-app-rewired": "^2.2.1",
8787
"react-scripts": "5.0.1",

web-app/src/screens/Console/Account/Account.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,8 @@ const Account = () => {
179179
},
180180
];
181181

182-
const filteredRecords = records.filter(
183-
(elementItem) =>
184-
elementItem?.accessKey?.toLowerCase().includes(filter.toLowerCase()),
182+
const filteredRecords = records.filter((elementItem) =>
183+
elementItem?.accessKey?.toLowerCase().includes(filter.toLowerCase()),
185184
);
186185

187186
return (

web-app/src/screens/Console/KMS/ImportKey.tsx

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,34 +27,41 @@ import {
2727
} from "mds";
2828
import { useNavigate } from "react-router-dom";
2929
import { IAM_PAGES } from "../../../common/SecureComponent/permissions";
30-
import { ErrorResponseHandler } from "../../../common/types";
3130
import { setErrorSnackMessage, setHelpName } from "../../../systemSlice";
3231
import { useAppDispatch } from "../../../store";
3332
import { modalStyleUtils } from "../Common/FormComponents/common/styleLibrary";
34-
import useApi from "../Common/Hooks/useApi";
3533
import KMSHelpBox from "./KMSHelpbox";
3634
import PageHeaderWrapper from "../Common/PageHeaderWrapper/PageHeaderWrapper";
3735
import HelpMenu from "../HelpMenu";
36+
import { api } from "api";
37+
import { ApiError, HttpResponse } from "api/consoleApi";
38+
import { errorToHandler } from "api/errors";
3839

3940
export const emptyContent = '{\n "bytes": ""\n}';
4041

4142
const ImportKey = () => {
4243
const dispatch = useAppDispatch();
4344
const navigate = useNavigate();
4445

45-
const onSuccess = () => navigate(`${IAM_PAGES.KMS_KEYS}`);
46-
47-
const onError = (err: ErrorResponseHandler) =>
48-
dispatch(setErrorSnackMessage(err));
49-
50-
const [loading, invokeApi] = useApi(onSuccess, onError);
46+
const [loadingImport, setLoadingImport] = useState<boolean>(false);
5147
const [keyName, setKeyName] = useState<string>("");
5248
const [keyContent, setKeyContent] = useState<string>(emptyContent);
5349

5450
const importRecord = (event: React.FormEvent) => {
51+
setLoadingImport(true);
5552
event.preventDefault();
5653
let data = JSON.parse(keyContent);
57-
invokeApi("POST", `/api/v1/kms/keys/${keyName}/import`, data);
54+
55+
api.kms
56+
.kmsImportKey(keyName, data)
57+
.then((_) => {
58+
navigate(`${IAM_PAGES.KMS_KEYS}`);
59+
})
60+
.catch(async (res: HttpResponse<void, ApiError>) => {
61+
const err = (await res.json()) as ApiError;
62+
dispatch(setErrorSnackMessage(errorToHandler(err)));
63+
})
64+
.finally(() => setLoadingImport(false));
5865
};
5966

6067
const resetForm = () => {
@@ -140,7 +147,7 @@ const ImportKey = () => {
140147
type="submit"
141148
variant="callAction"
142149
color="primary"
143-
disabled={loading || !validSave}
150+
disabled={loadingImport || !validSave}
144151
label={"Import"}
145152
/>
146153
</Grid>

web-app/src/screens/Console/Policies/ListPolicies.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,8 @@ const ListPolicies = () => {
159159
},
160160
];
161161

162-
const filteredRecords = records.filter(
163-
(elementItem) => elementItem.name?.includes(filterPolicies),
162+
const filteredRecords = records.filter((elementItem) =>
163+
elementItem.name?.includes(filterPolicies),
164164
);
165165

166166
useEffect(() => {

web-app/tsconfig.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"downlevelIteration": true,
1818
"noFallthroughCasesInSwitch": true,
1919
"baseUrl": "./src",
20-
"rootDir": "./src"
20+
"rootDir": "./src",
2121
},
22-
"include": ["src"]
22+
"include": ["src"],
2323
}

web-app/yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9954,10 +9954,10 @@ prelude-ls@~1.1.2:
99549954
resolved "https://registry.yarnpkg.com/prelude-ls/-/prelude-ls-1.1.2.tgz#21932a549f5e52ffd9a827f570e04be62a97da54"
99559955
integrity sha512-ESF23V4SKG6lVSGZgYNpbsiaAkdab6ZgOxe52p7+Kid3W3u3bxR4Vfd/o21dmN7jSt0IwgZ4v5MUd26FEtXE9w==
99569956

9957-
prettier@3.1.1:
9958-
version "3.1.1"
9959-
resolved "https://registry.yarnpkg.com/prettier/-/prettier-3.1.1.tgz#6ba9f23165d690b6cbdaa88cb0807278f7019848"
9960-
integrity sha512-22UbSzg8luF4UuZtzgiUOfcGM8s4tjBv6dJRT7j275NXsy2jb4aJa4NNveul5x4eqlF1wuhuR2RElK71RvmVaw==
9957+
prettier@3.2.4:
9958+
version "3.2.4"
9959+
resolved "https://registry.yarnpkg.com/prettier/-/prettier-3.2.4.tgz#4723cadeac2ce7c9227de758e5ff9b14e075f283"
9960+
integrity sha512-FWu1oLHKCrtpO1ypU6J0SbK2d9Ckwysq6bHj/uaCP26DxrPpppCLQRGVuqAxSTvhF00AcvDRyYrLNW7ocBhFFQ==
99619961

99629962
pretty-bytes@^5.3.0, pretty-bytes@^5.4.1:
99639963
version "5.6.0"

0 commit comments

Comments
 (0)