File tree Expand file tree Collapse file tree 1 file changed +5
-5
lines changed
internal/framework/events Expand file tree Collapse file tree 1 file changed +5
-5
lines changed Original file line number Diff line number Diff line change @@ -14,11 +14,11 @@ import (
1414// - Otherwise, the new event will be saved for later handling. All saved events will be handled after the handling of
1515// the current event(s) finishes. Multiple saved events will be handled at once -- they will be batched.
1616//
17- // Batching is needed because, because typically handling an event (or multiple events at once) will result into
18- // reloading NGINX, which is the operation we want to minimize, for the following reasons:
19- // (1) A reload takes time - at least 200ms. The time depends on the size of the configuration including the number of
20- // TLS certs, available CPU cycles.
21- // (2) A reload can have side-effects for the data plane traffic.
17+ // Batching is needed because handling an event (or multiple events at once) will typically result in
18+ // reloading NGINX, which is an operation we want to minimize for the following reasons:
19+ // (1) A reload takes time - at least 200ms. The time depends on the size of the configuration, the number of
20+ // TLS certs, and the number of available CPU cycles.
21+ // (2) A reload can have side-effects for data plane traffic.
2222// FIXME(pleshakov): better document the side effects and how to prevent and mitigate them.
2323// So when the EventLoop have 100 saved events, it is better to process them at once rather than one by one.
2424// https://github.com/nginxinc/nginx-gateway-fabric/issues/551
You can’t perform that action at this time.
0 commit comments