Skip to content
This repository was archived by the owner on Jul 27, 2024. It is now read-only.

Conversation

hironytic
Copy link
Contributor

With this patch,

before

becomes

after

("Base16 Tomorrow Dark" theme is selected in this screenshot.)

@miketheman
Copy link
Owner

This looks correct - however I was looking for some docs on the distinction between syntax-variables and ui-variables - do you know where I can find them?

@hironytic
Copy link
Contributor Author

I don't know much. 😔
In fact, I searched over docs before PR but I couldn't find it.

This document mentions UI theme and syntax theme. But I'm not sure ui-variables and syntax-variables are them.

@hironytic
Copy link
Contributor Author

It turns out that syntax-variables should be imported.

Importing ui-variables works if UI theme is 'One Dark', but it doesn't if UI theme is 'Atom Dark'. Because

I also found in Atom Template Syntax Theme,

  • Define proper colors in your syntax-variables.less file. Other packages
    can use these variables. All the variables defined in this package's
    syntax-variables.less file must be defined — you cannot pick and choose.

and @syntax-color-(added|modified|removed) was defined in syntax-variables.less.

miketheman added a commit that referenced this pull request Nov 11, 2015
@miketheman miketheman merged commit b4765ea into miketheman:master Nov 11, 2015
@miketheman
Copy link
Owner

Thanks for looking into the details. Merging and releasing now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants