Skip to content

Remove unnecessary removeEventListeners on destroy #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikededo opened this issue Sep 18, 2024 · 0 comments
Closed

Remove unnecessary removeEventListeners on destroy #3

mikededo opened this issue Sep 18, 2024 · 0 comments
Assignees

Comments

@mikededo
Copy link
Owner

Some actions used in the codebase include a return destroy function. In most of this functions I simply remove the events that have been previously added to the node to which the action is binded to. However, this is not required as the events will automatically be removed once the element is destroyed (see a similar issue from Rich Harris).

The idea is to remove all unnecessary destroys and removeEventListener's.

@mikededo mikededo self-assigned this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant