Skip to content

Commit cedacb5

Browse files
committed
fix: remove unnecessary destroy
Closes #3
1 parent c2014ac commit cedacb5

File tree

10 files changed

+3
-70
lines changed

10 files changed

+3
-70
lines changed

apps/finance/src/lib/domain/budget/actions.svelte.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,4 @@ export const useUpDownArrows: Action<HTMLElement, string> = (node, prefix) => {
129129
};
130130

131131
node.addEventListener('keydown', onKeydown);
132-
133-
return {
134-
destroy() {
135-
node.removeEventListener('keydown', onKeydown);
136-
}
137-
};
138132
};

apps/finance/src/lib/domain/page/table/entry.svelte

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,6 @@
8989
};
9090
9191
node.addEventListener('keydown', onKeydown);
92-
93-
return {
94-
destroy() {
95-
node.removeEventListener('keydown', onKeydown);
96-
}
97-
};
9892
};
9993
10094
const onInternalClickAway = (event: MouseEvent) => {

apps/finance/src/lib/domain/tags/menu/autocomplete-menu-list.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,4 @@ export const useInputMenuOption: Action<HTMLElement, UseMenuOptionArgs> = (
3030

3131
node.addEventListener('keydown', onKeydown);
3232
node.addEventListener('mousedown', onOptionClick);
33-
34-
return {
35-
destroy() {
36-
node.removeEventListener('keydown', onKeydown);
37-
node.removeEventListener('mousedown', onOptionClick);
38-
}
39-
};
4033
};

packages/actions/src/date-mask.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,4 @@ export const useDateMask: Action = (node) => {
4646

4747
node.addEventListener('input', onInput, true);
4848
node.addEventListener('keydown', onKeydown);
49-
50-
return {
51-
destroy() {
52-
node.removeEventListener('input', onInput, true);
53-
node.removeEventListener('keydown', onKeydown);
54-
}
55-
};
5649
};

packages/actions/src/use-money-mask.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,6 @@ export const useMoneyMask: Action = (node) => {
2828
};
2929

3030
node.addEventListener('input', onInput, true);
31-
3231
// Register also the prefix of the currency
33-
const prefix = usePrefix(node, '€ ');
34-
35-
return {
36-
destroy() {
37-
node.removeEventListener('input', onInput, true);
38-
prefix.destroy?.();
39-
}
40-
};
32+
usePrefix(node, '€ ');
4133
};

packages/actions/src/use-percentage-mask.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,5 @@ export const usePercentageMask: Action = (node) => {
2222
};
2323

2424
node.addEventListener('input', onInput, true);
25-
26-
const prefix = usePrefix(node, '% ');
27-
28-
return {
29-
destroy() {
30-
node.removeEventListener('input', onInput, true);
31-
prefix.destroy?.();
32-
}
33-
};
25+
usePrefix(node, '% ');
3426
};

packages/actions/src/use-prefix.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
import type { ActionReturn } from 'svelte/action';
2-
3-
export const usePrefix = (node: HTMLInputElement, prefix: string): ActionReturn => {
1+
export const usePrefix = (node: HTMLInputElement, prefix: string): void => {
42
const onInput = () => {
53
if (!node.value.startsWith(prefix) && node.value) {
64
node.value = prefix + node.value;
@@ -11,10 +9,4 @@ export const usePrefix = (node: HTMLInputElement, prefix: string): ActionReturn
119

1210
node.addEventListener('input', onInput, true);
1311
onInput();
14-
15-
return {
16-
destroy() {
17-
node.removeEventListener('input', onInput, true);
18-
}
19-
};
2012
};

packages/actions/src/use-trap-focus.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,4 @@ export const useTrapFocus: Action = (node) => {
1919
};
2020

2121
node.addEventListener('keydown', onKeydown);
22-
23-
return {
24-
destroy() {
25-
node.removeEventListener('keydown', onKeydown);
26-
}
27-
};
2822
};

packages/ui/src/drawer/drawer.svelte

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,6 @@
6262
};
6363
6464
node.addEventListener('click', onClick);
65-
66-
return {
67-
destroy() {
68-
node.removeEventListener('click', onClick);
69-
}
70-
};
7165
};
7266
7367
$effect(() => {

packages/ui/src/tabs/tabs.svelte

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,6 @@
3030
};
3131
3232
node.addEventListener('click', onClick);
33-
return {
34-
destroy() {
35-
node.removeEventListener('click', onClick);
36-
}
37-
};
3833
};
3934
4035
$effect(() => {

0 commit comments

Comments
 (0)