Skip to content

Commit 0b7a9eb

Browse files
committed
fix warning
1 parent e5a89ab commit 0b7a9eb

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

src/package.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1432,17 +1432,6 @@ export function validateManifestForPackaging(manifest: UnverifiedManifest): Mani
14321432
validateExtensionDependencies(manifest.extensionDependencies, 'extensionDependencies');
14331433
validateExtensionDependencies(manifest.extensionPack, 'extensionPack');
14341434

1435-
// Warn about deprecated github.copilot dependency
1436-
const allDependencies = [
1437-
...(manifest.extensionDependencies || []),
1438-
...(manifest.extensionPack || [])
1439-
];
1440-
if (allDependencies.includes('github.copilot')) {
1441-
util.log.warn(
1442-
`The "github.copilot" extension is being deprecated. Please use "github.copilot-chat" instead.`
1443-
);
1444-
}
1445-
14461435
return {
14471436
...manifest,
14481437
name,

src/validation.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import * as semver from 'semver';
22
import parseSemver from 'parse-semver';
3+
import { log } from './util';
34

45
const nameRegex = /^[a-z0-9][a-z0-9\-]*$/i;
56

@@ -136,6 +137,12 @@ export function validateExtensionDependencies(dependencies: string[] | undefined
136137
if (dep !== dep.toLowerCase()) {
137138
invalidDependencies.push(dep);
138139
}
140+
141+
if (dep === 'github.copilot') {
142+
log.warn(
143+
`The "github.copilot" extension is being deprecated in favor of the "github.copilot-chat" extension. Please use "github.copilot-chat" in ${fieldName} instead.`
144+
);
145+
}
139146
}
140147

141148
if (invalidDependencies.length > 0) {

0 commit comments

Comments
 (0)