Skip to content

Update image #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Update image #18

merged 1 commit into from
Sep 6, 2022

Conversation

bamurtaugh
Copy link
Member

No description provided.

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@vadi2
Copy link

vadi2 commented Sep 3, 2022

I use this template - should I update it in mine as well?

@bamurtaugh
Copy link
Member Author

Thanks for all the approvals @samruddhikhandale 😄

@vadi2 Yes, I'd recommend you update the image! There's more context here: microsoft/vscode-dev-containers#1589.

@bamurtaugh
Copy link
Member Author

@samruddhikhandale Super odd, but it looks like I'm still blocked from merging - I think these PRs may require an actual approving review step? Would you be able to try again?

@samruddhikhandale
Copy link
Member

@bamurtaugh Looking at the PR status, someone with write access to the repos needs to approve as well.
Apparently, I don’t have that 😓 Probably @Chuxel could help?

@bamurtaugh
Copy link
Member Author

Thanks for looking into this @samruddhikhandale!

@Chuxel I looked into adding write access for Samruddhi to this repo, but I couldn't access the access tab I think I'd need to use. Any thoughts?

@Chuxel Chuxel self-requested a review September 6, 2022 18:16
@bamurtaugh bamurtaugh merged commit c8f1d4b into main Sep 6, 2022
@bamurtaugh bamurtaugh deleted the bamurtaugh-patch-1 branch September 6, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants