Skip to content

Use the new debug adapter with DS if both experiments are enabled #8365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

DonJayamanne
Copy link

For #6907

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Nov 4, 2019
@kimadeline
Copy link

Can DS debugging be done with any version of Python? The new DA should only be used with python 3.7.

@codecov-io
Copy link

Codecov Report

Merging #8365 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8365   +/-   ##
=======================================
  Coverage   59.23%   59.23%           
=======================================
  Files         508      508           
  Lines       23236    23236           
  Branches     3750     3750           
=======================================
  Hits        13765    13765           
  Misses       8577     8577           
  Partials      894      894
Impacted Files Coverage Δ
src/client/datascience/jupyter/jupyterDebugger.ts 10.47% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b19d0...2a35dc9. Read the comment docs.

@DonJayamanne
Copy link
Author

@kimadeline We're already checking that, see here

if (!pythonVersion || pythonVersion.major < 3 || pythonVersion.minor < 7){

@DonJayamanne DonJayamanne merged commit b202ad2 into microsoft:master Nov 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 11, 2019
@DonJayamanne DonJayamanne deleted the fixDSDebuggerExp branch November 15, 2019 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants