Fixed plots by adding extra check in transformOutput #8343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transformOutput. Also added the prop key to some outputs to avoid errors in the console.
rchiodo
reviewed
Nov 1, 2019
| @@ -353,7 +353,7 @@ export class CellOutput extends React.Component<ICellOutputProps> { | |||
| const buffer: JSX.Element[] = []; | |||
| const transformedList = outputs.map(this.transformOutput); | |||
There was a problem hiding this comment.
transformOutput [](start = 49, length = 15)
This should instead be this.transformOutput.bind(this), then you wouldn't need to check the this pointer above
Codecov Report
@@ Coverage Diff @@
## master #8343 +/- ##
=======================================
Coverage 59.23% 59.23%
=======================================
Files 508 508
Lines 23236 23236
Branches 3750 3750
=======================================
Hits 13765 13765
Misses 8577 8577
Partials 894 894Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8342
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)