Skip to content

Move language server files to a 'activation/languageServer' folder #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2018

Conversation

lsfgrd
Copy link

@lsfgrd lsfgrd commented Oct 2, 2018

For #2756.

Moved the files and updated all the related imports.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [x] Unit tests & system/integration tests are added/updated
  • [x] Any new/changed dependencies in package.json are pinned (e.g. "1.2.3", not "^1.2.3" for the specified version)
  • [x] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@msftclas
Copy link

msftclas commented Oct 2, 2018

CLA assistant check
All CLA requirements met.

Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not require any changes to package-lock.json, please revert the changes to that file.

@lsfgrd
Copy link
Author

lsfgrd commented Oct 3, 2018

Oops! Fixed that!

@DonJayamanne DonJayamanne merged commit cdd1bf6 into microsoft:master Oct 9, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants