Skip to content

LS settings for typeshed and diagnostics #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 29, 2018
Merged

LS settings for typeshed and diagnostics #2065

merged 11 commits into from
Jun 29, 2018

Conversation

MikhailArkhipov
Copy link

@MikhailArkhipov MikhailArkhipov commented Jun 27, 2018

Fixes #2030

Adds options to control diagnostics
Adds option to 'open files only'
Adds option for typeshed paths
Controls when to restart LS so we we don't reload on trivial settings change

This pull request:

  • Has a title summarizes what is changing
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

Tests are to be added on PTVS side, I can add one integration test to VSC.

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #2065 into master will decrease coverage by 0.13%.
The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2065      +/-   ##
==========================================
- Coverage   79.95%   79.82%   -0.14%     
==========================================
  Files         307      307              
  Lines       14064    14086      +22     
  Branches     2494     2499       +5     
==========================================
- Hits        11245    11244       -1     
- Misses       2807     2830      +23     
  Partials       12       12
Flag Coverage Δ
#MacOS 74% <26.66%> (-0.09%) ⬇️
#Windows 74.08% <26.66%> (-0.1%) ⬇️
Impacted Files Coverage Δ
src/client/common/types.ts 100% <ø> (ø) ⬆️
src/client/common/configSettings.ts 91.52% <100%> (+0.19%) ⬆️
src/client/activation/analysis.ts 25.86% <19.51%> (-2.35%) ⬇️
...unittests/common/testVisitors/flatteningVisitor.ts 84.61% <0%> (-2.57%) ⬇️
src/client/interpreter/helpers.ts 88.37% <0%> (-2.33%) ⬇️
src/client/common/process/pythonProcess.ts 93.18% <0%> (-2.28%) ⬇️
...reter/locators/services/cacheableLocatorService.ts 93.87% <0%> (-2.05%) ⬇️
src/client/common/platform/fileSystem.ts 71.42% <0%> (-1.2%) ⬇️
src/client/interpreter/interpreterService.ts 81.05% <0%> (-1.06%) ⬇️
src/client/unittests/main.ts 46.69% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b769f55...781ccb9. Read the comment docs.

@MikhailArkhipov MikhailArkhipov merged commit cda34d4 into microsoft:master Jun 29, 2018
@MikhailArkhipov MikhailArkhipov deleted the typeshed branch June 29, 2018 16:46
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LS option to only show errors in open files
2 participants