Skip to content

Add dynamic FastAPI debug config #19505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2022
Merged

Add dynamic FastAPI debug config #19505

merged 2 commits into from
Jul 21, 2022

Conversation

paulacamargo25
Copy link

closed: #19452

@paulacamargo25 paulacamargo25 self-assigned this Jul 20, 2022
@paulacamargo25 paulacamargo25 added area-debugging feature-request Request for new features or functionality skip tests Updates to tests unnecessary labels Jul 20, 2022
@paulacamargo25 paulacamargo25 added this to the July 2022 milestone Jul 20, 2022
karrtikr
karrtikr suggested changes Jul 20, 2022
View reviewed changes
@paulacamargo25 paulacamargo25 requested a review from karrtikr July 21, 2022 20:58
karrtikr
karrtikr approved these changes Jul 21, 2022
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of Django as well, LGTM.

@paulacamargo25 paulacamargo25 merged commit 7c3498c into microsoft:main Jul 21, 2022
Kludex
Kludex reviewed Aug 4, 2022
View reviewed changes
src/client/debugger/extension/configuration/dynamicdebugConfigurationService.ts
private async getFastApiPath(folder: WorkspaceFolder) {
const possiblePaths = await this.getPossiblePaths(folder, ['main.py', 'app.py', '*/main.py', '*/app.py']);
const regExpression = /app\s*=\s*FastAPI\(/;
const flaskPaths = await asyncFilter(possiblePaths, async (possiblePath) =>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fastapi paths

wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@paulacamargo25 @wesm
Add dynamic FastAPI debug config (microsoft/vscode-python#19505)
292a677 
* Add dynamic FastAPI debug config

* Improve performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex left review comments

@karrtikr karrtikr karrtikr approved these changes

Assignees

@paulacamargo25 paulacamargo25

Labels
area-debugging feature-request Request for new features or functionality skip tests Updates to tests unnecessary
Projects
None yet
Milestone
July 2022
Development

Successfully merging this pull request may close these issues.

Implement automatic configuration for FastAPI
3 participants
@paulacamargo25 @Kludex @karrtikr