Skip to content

Remove output from report issue command template #17497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Remove output from report issue command template #17497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/report_issue_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ You can attach such things **after** you create your issue on GitHub.
<!-- Run the "Python: Show Output" command to see the requested output. --->

```
{3}

```

</p>
Expand All @@ -53,7 +53,7 @@ You can attach such things **after** you create your issue on GitHub.
<p>

```
{4}
{3}
```

</p>
Expand Down
4 changes: 1 addition & 3 deletions src/client/common/application/commands/reportIssueCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { ICommandManager, IWorkspaceService } from '../types';
import { EXTENSION_ROOT_DIR } from '../../../constants';
import { IInterpreterService, IInterpreterVersionService } from '../../../interpreter/contracts';
import { identifyEnvironment } from '../../../pythonEnvironments/common/environmentIdentifier';
import { getPythonOutputChannelContent } from '../../../logging';
import { Commands } from '../../constants';
import { IConfigurationService, IPythonSettings } from '../../types';

Expand Down Expand Up @@ -63,7 +62,6 @@ export class ReportIssueCommandHandler implements IExtensionSingleActivationServ
}
}
});
const pythonLogs = await getPythonOutputChannelContent();
const template = await fs.readFile(this.templatePath, 'utf8');
const interpreterPath = (await this.interpreterService.getActiveInterpreter())?.path || 'not-selected';
const pythonVersion = await this.interpreterVersionService.getVersion(interpreterPath, '');
Expand All @@ -73,7 +71,7 @@ export class ReportIssueCommandHandler implements IExtensionSingleActivationServ

this.commandManager.executeCommand('workbench.action.openIssueReporter', {
extensionId: 'ms-python.python',
issueBody: template.format(pythonVersion, virtualEnv, languageServer, pythonLogs, userSettings),
issueBody: template.format(pythonVersion, virtualEnv, languageServer, userSettings),
});
}
}
2 changes: 1 addition & 1 deletion src/test/common/application/commands/issueTemplateVenv1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ You can attach such things **after** you create your issue on GitHub.
<!-- Run the "Python: Show Output" command to see the requested output. --->

```
Python Output

```

</p>
Expand Down