Skip to content

Display a notification when using JediLSP with Python 2.7 #17407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Sep 14, 2021

Conversation

kimadeline
Copy link

@kimadeline kimadeline commented Sep 13, 2021

For #17512

image

Using a diagnostic as discussed in the previous PR.

Deleting all Jedi-related stuff will be in a separate PR ♻️

@kimadeline kimadeline added the no-changelog No news entry required label Sep 13, 2021
@kimadeline kimadeline self-assigned this Sep 13, 2021
@kimadeline kimadeline added this to the September 2021 milestone Sep 13, 2021
@kimadeline kimadeline marked this pull request as ready for review September 14, 2021 00:19
@kimadeline kimadeline requested a review from karrtikr September 14, 2021 00:20
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@kimadeline kimadeline merged commit 8e3f522 into microsoft:main Sep 14, 2021
@kimadeline kimadeline deleted the 11995-27-notification branch September 14, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants