Skip to content

Update files to match new Prettier settings #15030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Dec 21, 2020

The key files to review are:

  1. .eslintrc
  2. .prettierrc.js
  3. The deletion of .prettierignore
  4. package.json

@github-actions github-actions bot requested a review from karrtikr December 21, 2020 23:00
@github-actions github-actions bot requested a review from kimadeline December 21, 2020 23:00
@brettcannon brettcannon added the no-changelog No news entry required label Dec 21, 2020
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #15030 (c344f9c) into main (790f6d7) will increase coverage by 0%.
The diff coverage is 83%.

@@          Coverage Diff           @@
##            main   #15030   +/-   ##
======================================
  Coverage     65%      65%           
======================================
  Files        558      558           
  Lines      26226    26222    -4     
  Branches    3717     3719    +2     
======================================
- Hits       17152    17150    -2     
+ Misses      8381     8378    -3     
- Partials     693      694    +1     
Impacted Files Coverage Δ
src/client/activation/common/analysisOptions.ts 59% <ø> (ø)
src/client/activation/common/cancellationUtils.ts 13% <ø> (ø)
...c/client/activation/common/downloadChannelRules.ts 100% <ø> (ø)
src/client/activation/jedi.ts 21% <0%> (ø)
src/client/activation/jedi/activator.ts 70% <ø> (ø)
src/client/activation/jedi/analysisOptions.ts 71% <ø> (ø)
...rc/client/activation/jedi/languageClientFactory.ts 40% <ø> (ø)
src/client/activation/jedi/languageServerProxy.ts 25% <0%> (ø)
src/client/activation/jedi/manager.ts 29% <ø> (ø)
...rc/client/activation/jedi/multiplexingActivator.ts 17% <0%> (ø)
... and 309 more

@brettcannon brettcannon merged commit db8e1e2 into microsoft:main Dec 21, 2020
@brettcannon brettcannon deleted the update-prettier branch December 21, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants