terminal_shell_identification telemetry only fires on failure

[brettcannon]

Without an equivalent success metric there's no easy way to measure if there's an increase/decrease in success relative to usage growth.

[karrtikr]

It turns out failed was always set as true even though we successfully detected the shell type.